Revert of Import web-platform-tests@5a8700479d98852455bee6117558897867eb278a

Revert of Import web-platform-tests@5a8700479d98852455bee6117558897867eb278a (patchset #8 id:140001 of https://codereview.chromium.org/1866333004/ )

Reason for revert:
Suspected culprit of bot breakage, see http://crbug.com/600248#c5.

Original issue's description:
> Import web-platform-tests@5a8700479d98852455bee6117558897867eb278a
>
> Using update-w3c-deps in Blink bf7dc636b3ed84582375d2cebe613ffaf1c00794.
>
> This patch adds web-animations to the list of directories imported
> from web-platform-tests.
>
> BUG=600248
>
> Committed: https://crrev.com/5948d8b9cd8325cb75b9d903d25d566529b83a00
> Cr-Commit-Position: refs/heads/master@{#386923}

TBR=alancutter@chromium.org,jsbell@chromium.org,suzyh@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
# Let's make sure that this compiles:
NOTRY=false
BUG=600248
Committed: https://crrev.com/ac46f2734a2d5ebd52615a7a3678ebae5749a405
Cr-Commit-Position: refs/heads/master@{#386977}

[vabr (Chromium), 2016-04-13 12:28:29]

Created Revert of Import
web-platform-tests@5a8700479d98852455bee6117558897867eb278a

[vabr (Chromium), 2016-04-13 12:28:37]

The CQ bit was unchecked by vabr@chromium.org

[commit-bot: I haz the power, 2016-04-13 12:28:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1883663003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1883663003/1

[commit-bot: I haz the power, 2016-04-13 12:28:44]

The CQ bit was unchecked by commit-bot@chromium.org

[vabr (Chromium), 2016-04-13 12:29:31]

Description was changed from

==========
Revert of Import web-platform-tests@5a8700479d98852455bee6117558897867eb278a
(patchset #8 id:140001 of https://codereview.chromium.org/1866333004/ )

Reason for revert:
Suspected culprit of bot breakage, see http://crbug.com/600248#c5.

Original issue's description:
> Import web-platform-tests@5a8700479d98852455bee6117558897867eb278a
> 
> Using update-w3c-deps in Blink bf7dc636b3ed84582375d2cebe613ffaf1c00794.
> 
> This patch adds web-animations to the list of directories imported
> from web-platform-tests.
> 
> BUG=600248
> 
> Committed: https://crrev.com/5948d8b9cd8325cb75b9d903d25d566529b83a00
> Cr-Commit-Position: refs/heads/master@{#386923}

TBR=alancutter@chromium.org,jsbell@chromium.org,suzyh@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=600248
==========

to

==========
Revert of Import web-platform-tests@5a8700479d98852455bee6117558897867eb278a
(patchset #8 id:140001 of https://codereview.chromium.org/1866333004/ )

Reason for revert:
Suspected culprit of bot breakage, see http://crbug.com/600248#c5.

Original issue's description:
> Import web-platform-tests@5a8700479d98852455bee6117558897867eb278a
> 
> Using update-w3c-deps in Blink bf7dc636b3ed84582375d2cebe613ffaf1c00794.
> 
> This patch adds web-animations to the list of directories imported
> from web-platform-tests.
> 
> BUG=600248
> 
> Committed: https://crrev.com/5948d8b9cd8325cb75b9d903d25d566529b83a00
> Cr-Commit-Position: refs/heads/master@{#386923}

TBR=alancutter@chromium.org,jsbell@chromium.org,suzyh@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
# Let's make sure that this compiles:
NOTRY=false
BUG=600248
==========

[vabr (Chromium), 2016-04-13 12:29:37]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-04-13 12:29:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1883663003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1883663003/1

[commit-bot: I haz the power, 2016-04-13 13:37:55]

Description was changed from

==========
Revert of Import web-platform-tests@5a8700479d98852455bee6117558897867eb278a
(patchset #8 id:140001 of https://codereview.chromium.org/1866333004/ )

Reason for revert:
Suspected culprit of bot breakage, see http://crbug.com/600248#c5.

Original issue's description:
> Import web-platform-tests@5a8700479d98852455bee6117558897867eb278a
> 
> Using update-w3c-deps in Blink bf7dc636b3ed84582375d2cebe613ffaf1c00794.
> 
> This patch adds web-animations to the list of directories imported
> from web-platform-tests.
> 
> BUG=600248
> 
> Committed: https://crrev.com/5948d8b9cd8325cb75b9d903d25d566529b83a00
> Cr-Commit-Position: refs/heads/master@{#386923}

TBR=alancutter@chromium.org,jsbell@chromium.org,suzyh@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
# Let's make sure that this compiles:
NOTRY=false
BUG=600248
==========

to

==========
Revert of Import web-platform-tests@5a8700479d98852455bee6117558897867eb278a
(patchset #8 id:140001 of https://codereview.chromium.org/1866333004/ )

Reason for revert:
Suspected culprit of bot breakage, see http://crbug.com/600248#c5.

Original issue's description:
> Import web-platform-tests@5a8700479d98852455bee6117558897867eb278a
> 
> Using update-w3c-deps in Blink bf7dc636b3ed84582375d2cebe613ffaf1c00794.
> 
> This patch adds web-animations to the list of directories imported
> from web-platform-tests.
> 
> BUG=600248
> 
> Committed: https://crrev.com/5948d8b9cd8325cb75b9d903d25d566529b83a00
> Cr-Commit-Position: refs/heads/master@{#386923}

TBR=alancutter@chromium.org,jsbell@chromium.org,suzyh@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
# Let's make sure that this compiles:
NOTRY=false
BUG=600248
==========

[commit-bot: I haz the power, 2016-04-13 13:37:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-13 13:39:42]

Description was changed from

==========
Revert of Import web-platform-tests@5a8700479d98852455bee6117558897867eb278a
(patchset #8 id:140001 of https://codereview.chromium.org/1866333004/ )

Reason for revert:
Suspected culprit of bot breakage, see http://crbug.com/600248#c5.

Original issue's description:
> Import web-platform-tests@5a8700479d98852455bee6117558897867eb278a
> 
> Using update-w3c-deps in Blink bf7dc636b3ed84582375d2cebe613ffaf1c00794.
> 
> This patch adds web-animations to the list of directories imported
> from web-platform-tests.
> 
> BUG=600248
> 
> Committed: https://crrev.com/5948d8b9cd8325cb75b9d903d25d566529b83a00
> Cr-Commit-Position: refs/heads/master@{#386923}

TBR=alancutter@chromium.org,jsbell@chromium.org,suzyh@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
# Let's make sure that this compiles:
NOTRY=false
BUG=600248
==========

to

==========
Revert of Import web-platform-tests@5a8700479d98852455bee6117558897867eb278a
(patchset #8 id:140001 of https://codereview.chromium.org/1866333004/ )

Reason for revert:
Suspected culprit of bot breakage, see http://crbug.com/600248#c5.

Original issue's description:
> Import web-platform-tests@5a8700479d98852455bee6117558897867eb278a
>
> Using update-w3c-deps in Blink bf7dc636b3ed84582375d2cebe613ffaf1c00794.
>
> This patch adds web-animations to the list of directories imported
> from web-platform-tests.
>
> BUG=600248
>
> Committed: https://crrev.com/5948d8b9cd8325cb75b9d903d25d566529b83a00
> Cr-Commit-Position: refs/heads/master@{#386923}

TBR=alancutter@chromium.org,jsbell@chromium.org,suzyh@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
# Let's make sure that this compiles:
NOTRY=false
BUG=600248

Committed: https://crrev.com/ac46f2734a2d5ebd52615a7a3678ebae5749a405
Cr-Commit-Position: refs/heads/master@{#386977}
==========

[commit-bot: I haz the power, 2016-04-13 13:39:43]

Patchset 1 (id:??) landed as
https://crrev.com/ac46f2734a2d5ebd52615a7a3678ebae5749a405
Cr-Commit-Position: refs/heads/master@{#386977}

[suzyh_UTC10 (ex-contributor), 2016-04-13 23:07:59]

In this case, since the failures were in new tests added by this patch (and
failing is already expected for most of the tests in the patch), I would have
preferred the TestExpectations file to be updated with the expected failures
rather than reverting the whole patch. But I realise that this option might not
have been apparent, so LGTM with thanks :)

[vabr (Chromium), 2016-04-14 10:49:01]

On 2016/04/13 23:07:59, suzyh wrote:
> In this case, since the failures were in new tests added by this patch (and
> failing is already expected for most of the tests in the patch), I would have
> preferred the TestExpectations file to be updated with the expected failures
> rather than reverting the whole patch. But I realise that this option might
not
> have been apparent, so LGTM with thanks :)

Yeah, sorry about that. The issue with the dissolved Blink gardening rotation is
that Chromium sheriffs now have twice as much breakages to look at, and hitting
a revert is easier than figuring out how tests work in Bling, how to update
expectations, getting someone to sanity-check it, etc. This is in general the
approach for any Chromium change -- as soon as the culprit is known, and if
there are other issues to be solved by the sheriff, just revert the culprit and
move on.

Cheers,
Vaclav