Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 188363002: [webcrypto] Add raw symmetric key RSAES-PKCS1-v1_5 wrap/unwrap for NSS. (Closed)

Created:
6 years, 9 months ago by padolph
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@wcAesKw_nss1
Visibility:
Public.

Description

[webcrypto] Add raw symmetric key RSAES-PKCS1-v1_5 wrap/unwrap for NSS. BUG=245025 TEST=content_unittests --gtest_filter="SharedCryptoTest*" Based on https://codereview.chromium.org/118623002/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256779

Patch Set 1 #

Patch Set 2 : removed new NSS function calls #

Total comments: 8

Patch Set 3 : fixes for eroman #

Patch Set 4 : rebase #

Total comments: 10

Patch Set 5 : fixes for eroman #

Patch Set 6 : rebase and fixes for eroman #

Patch Set 7 : minor comment fix #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+332 lines, -21 lines) Patch
M content/child/webcrypto/platform_crypto.h View 1 2 3 4 2 chunks +19 lines, -1 line 0 comments Download
M content/child/webcrypto/platform_crypto_nss.cc View 1 2 3 4 5 6 7 2 chunks +80 lines, -2 lines 0 comments Download
M content/child/webcrypto/platform_crypto_openssl.cc View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
M content/child/webcrypto/shared_crypto.cc View 1 2 3 4 5 3 chunks +34 lines, -11 lines 0 comments Download
M content/child/webcrypto/shared_crypto_unittest.cc View 1 2 3 4 5 6 7 8 chunks +182 lines, -7 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
padolph
6 years, 9 months ago (2014-03-06 03:06:07 UTC) #1
eroman
https://codereview.chromium.org/188363002/diff/20001/content/renderer/webcrypto/platform_crypto_nss.cc File content/renderer/webcrypto/platform_crypto_nss.cc (right): https://codereview.chromium.org/188363002/diff/20001/content/renderer/webcrypto/platform_crypto_nss.cc#newcode1214 content/renderer/webcrypto/platform_crypto_nss.cc:1214: if (input_length_bytes > modulus_length_bytes - 11) Is it possible ...
6 years, 9 months ago (2014-03-06 04:31:16 UTC) #2
padolph
https://codereview.chromium.org/188363002/diff/20001/content/renderer/webcrypto/platform_crypto_nss.cc File content/renderer/webcrypto/platform_crypto_nss.cc (right): https://codereview.chromium.org/188363002/diff/20001/content/renderer/webcrypto/platform_crypto_nss.cc#newcode1214 content/renderer/webcrypto/platform_crypto_nss.cc:1214: if (input_length_bytes > modulus_length_bytes - 11) On 2014/03/06 04:31:16, ...
6 years, 9 months ago (2014-03-10 19:02:53 UTC) #3
eroman
Good after addressing these comments (I will do another review pass before signing off). https://codereview.chromium.org/188363002/diff/70001/content/child/webcrypto/platform_crypto.h ...
6 years, 9 months ago (2014-03-10 21:35:57 UTC) #4
padolph
https://codereview.chromium.org/188363002/diff/70001/content/child/webcrypto/platform_crypto.h File content/child/webcrypto/platform_crypto.h (left): https://codereview.chromium.org/188363002/diff/70001/content/child/webcrypto/platform_crypto.h#oldcode189 content/child/webcrypto/platform_crypto.h:189: // * |algorithm.id()| is for a symmetric key algorithm. ...
6 years, 9 months ago (2014-03-10 23:50:00 UTC) #5
eroman
lgtm
6 years, 9 months ago (2014-03-11 04:06:19 UTC) #6
padolph
The CQ bit was checked by padolph@netflix.com
6 years, 9 months ago (2014-03-12 05:46:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/padolph@netflix.com/188363002/150001
6 years, 9 months ago (2014-03-12 05:49:20 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 08:00:14 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests, chrome_elf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=84033
6 years, 9 months ago (2014-03-12 08:00:15 UTC) #10
padolph
The CQ bit was checked by padolph@netflix.com
6 years, 9 months ago (2014-03-12 16:00:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/padolph@netflix.com/188363002/150001
6 years, 9 months ago (2014-03-12 16:00:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/padolph@netflix.com/188363002/150001
6 years, 9 months ago (2014-03-12 17:00:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/padolph@netflix.com/188363002/150001
6 years, 9 months ago (2014-03-12 19:16:45 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 22:26:17 UTC) #15
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests, chrome_elf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=84277
6 years, 9 months ago (2014-03-12 22:26:17 UTC) #16
padolph
The CQ bit was checked by padolph@netflix.com
6 years, 9 months ago (2014-03-13 06:57:36 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/padolph@netflix.com/188363002/150001
6 years, 9 months ago (2014-03-13 06:57:45 UTC) #18
commit-bot: I haz the power
6 years, 9 months ago (2014-03-13 10:03:54 UTC) #19
Message was sent while issue was closed.
Change committed as 256779

Powered by Google App Engine
This is Rietveld 408576698