Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1883623002: Correct normal computation for inverted polygons. (Closed)

Created:
4 years, 8 months ago by Peter Mayo
Modified:
4 years, 8 months ago
Reviewers:
Ian Vollick
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct normal computation for inverted polygons. Rather than rely solely the vertices, and their winding order for sign, we rely on the transform of the previous normal for the sign, and the vertices (cross product of edge vectors, similar to Newell's algorithm) for the numerics of the direction. BUG=595820 TEST=unittest CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/59d3768dd104c22554d86f410d22ad8f714c82eb Cr-Commit-Position: refs/heads/master@{#386984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -24 lines) Patch
M cc/quads/draw_polygon.cc View 4 chunks +14 lines, -6 lines 0 comments Download
M cc/quads/draw_polygon_unittest.cc View 9 chunks +16 lines, -18 lines 0 comments Download
M ui/gfx/transform.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/gfx/transform.cc View 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Peter Mayo
4 years, 8 months ago (2016-04-12 17:22:03 UTC) #3
Ian Vollick
On 2016/04/12 17:22:03, Peter Mayo wrote: Nice! lgtm if the bots are happy.
4 years, 8 months ago (2016-04-12 17:30:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883623002/1
4 years, 8 months ago (2016-04-12 18:29:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/49173)
4 years, 8 months ago (2016-04-12 18:37:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883623002/1
4 years, 8 months ago (2016-04-13 14:20:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 14:37:45 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 14:39:13 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59d3768dd104c22554d86f410d22ad8f714c82eb
Cr-Commit-Position: refs/heads/master@{#386984}

Powered by Google App Engine
This is Rietveld 408576698