Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1883593006: Remove never instantiated methods from PartitionAllocator. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove never instantiated methods from PartitionAllocator. R= BUG=585328 Committed: https://crrev.com/47f43a22863a14f14375ef7a02188cde3120937c Cr-Commit-Position: refs/heads/master@{#386944}

Patch Set 1 #

Patch Set 2 : compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -53 lines) Patch
M third_party/WebKit/Source/wtf/allocator/PartitionAllocator.h View 1 3 chunks +3 lines, -53 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look. Seems preferable to fail earlier if these methods are attempted instantiated ...
4 years, 8 months ago (2016-04-13 07:58:03 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-13 08:06:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883593006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883593006/20001
4 years, 8 months ago (2016-04-13 08:22:44 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-13 09:15:12 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 09:17:40 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/47f43a22863a14f14375ef7a02188cde3120937c
Cr-Commit-Position: refs/heads/master@{#386944}

Powered by Google App Engine
This is Rietveld 408576698