Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1883593002: Rename libchrome_zip to libzip_dart in build. (Closed)

Created:
4 years, 8 months ago by Bill Hesse
Modified:
4 years, 8 months ago
Reviewers:
terry, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, terry
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename libchrome_zip to libzip_dart in build. A condition was added to the libzip target in Chromium, renaming the output from libzip to libchrome_zip to avoid collisions with builtin libzip. We copied this to our libzip_dart target, so there was a collision in the Dartium build with two products called libchrome_zip. Removing this lets our copy be called libzip_dart. BUG= R=iposva@google.com, terry@google.com Committed: https://github.com/dart-lang/sdk/commit/3eded1245bb36dd218b74034829e3f122eb75071

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M runtime/bin/zlib.gyp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Bill Hesse
Tested on mac and linux. It has always had the other name on Windows. It ...
4 years, 8 months ago (2016-04-12 14:32:59 UTC) #2
terry
lgtm
4 years, 8 months ago (2016-04-12 14:48:00 UTC) #4
Ivan Posva
LGTM -ip
4 years, 8 months ago (2016-04-12 21:32:09 UTC) #5
Bill Hesse
4 years, 8 months ago (2016-04-12 22:15:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3eded1245bb36dd218b74034829e3f122eb75071 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698