Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1883583002: [compiler] Remove CompilationInfo::is_first_compile flag. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove CompilationInfo::is_first_compile flag. This removes the flag in question. It just duplicates the corresponding compilation hint in the underlying SharedFunctionInfo object. Now that the backends should have a SharedFunctionInfo available most of the time it is safe to use the cannonical predicate. R=bmeurer@chromium.org Committed: https://crrev.com/b958ba5fd830dd982e95cb162b433d89c8c65663 Cr-Commit-Position: refs/heads/master@{#35482}

Patch Set 1 #

Patch Set 2 : Workaround for Debug::live_edit_enabled being always true. #

Patch Set 3 : Rebased. #

Patch Set 4 : Fix CompileEvalForDebugging. #

Patch Set 5 : Cosmetics. #

Patch Set 6 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -26 lines) Patch
M src/compiler.h View 2 chunks +1 line, -8 lines 0 comments Download
M src/compiler.cc View 1 2 3 4 5 10 chunks +20 lines, -18 lines 0 comments Download
M src/objects.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Michael Starzinger
Benedikt: PTAL. Yang: FYI.
4 years, 8 months ago (2016-04-13 11:40:46 UTC) #3
Yang
On 2016/04/13 11:40:46, Michael Starzinger wrote: > Benedikt: PTAL. > Yang: FYI. LGTM
4 years, 8 months ago (2016-04-14 07:45:39 UTC) #4
Benedikt Meurer
LGTM.
4 years, 8 months ago (2016-04-14 09:14:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883583002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883583002/100001
4 years, 8 months ago (2016-04-14 10:25:49 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 8 months ago (2016-04-14 10:27:45 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 10:28:08 UTC) #12
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/b958ba5fd830dd982e95cb162b433d89c8c65663
Cr-Commit-Position: refs/heads/master@{#35482}

Powered by Google App Engine
This is Rietveld 408576698