Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1883533006: Properly create the store handler for lazy accessor pair setters (Closed)

Created:
4 years, 8 months ago by Toon Verwaest
Modified:
4 years, 8 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Properly create the store handler for lazy accessor pair setters BUG= Committed: https://crrev.com/a8b02cbce1cc3e9e73ea24309ebd0008a29885da Cr-Commit-Position: refs/heads/master@{#35425}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M src/ic/ic.cc View 2 chunks +15 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Toon Verwaest
ptal
4 years, 8 months ago (2016-04-12 15:57:38 UTC) #2
epertoso
lgtm
4 years, 8 months ago (2016-04-12 16:09:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883533006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883533006/1
4 years, 8 months ago (2016-04-12 16:31:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/27)
4 years, 8 months ago (2016-04-12 16:34:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883533006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883533006/1
4 years, 8 months ago (2016-04-12 18:37:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 18:52:09 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 18:53:08 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8b02cbce1cc3e9e73ea24309ebd0008a29885da
Cr-Commit-Position: refs/heads/master@{#35425}

Powered by Google App Engine
This is Rietveld 408576698