Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
188353002:
When the browser actions container's animation ended, we should set 'suppress_chevron_' to false th… (Closed)
|
Created:
6 years, 9 months ago by leiyi.jp Modified:
6 years, 9 months ago CC:
chromium-reviews, tfarina Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionWhen the browser actions container's animation ended, we should set 'suppress_chevron_' to false then re-layout it.
If we keep 'suppress_chevron_' being true and notify to re-layout the toolbar, then finish the animation, because there is no chance to layout toolbar again, some browser action views would not be showed, neither chevron. That makes people puzzled.
TBR=sky
R=finnur@chromium.org
BUG=328307
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255371
Patch Set 1 #
Messages
Total messages: 22 (0 generated)
LGTM.
The CQ bit was checked by finnur@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leiyi.jp@gmail.com/188353002/1
Thanks for the patch!
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg
The CQ bit was checked by finnur@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leiyi.jp@gmail.com/188353002/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
The CQ bit was checked by finnur@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leiyi.jp@gmail.com/188353002/1
The CQ bit was unchecked by finnur@chromium.org
Adding Scott as TBR for this one-liner fix.
The CQ bit was checked by finnur@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leiyi.jp@gmail.com/188353002/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_x64_rel for step(s) base_unittests, chrome_elf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...
The CQ bit was checked by finnur@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leiyi.jp@gmail.com/188353002/1
Message was sent while issue was closed.
Change committed as 255371 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
