Chromium Code Reviews Chromium Code Reviews
Issue 1883523002:
chrome://snippets-internals page for debugging NTP snippets. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/browser/resources/snippets_internals.html |
| diff --git a/chrome/browser/resources/snippets_internals.html b/chrome/browser/resources/snippets_internals.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..08f5b534f71868b6e1ef401bf3e81fce8f0e8203 |
| --- /dev/null |
| +++ b/chrome/browser/resources/snippets_internals.html |
| @@ -0,0 +1,135 @@ |
| +<!-- |
| +Copyright 2015 The Chromium Authors. All rights reserved. |
| +Use of this source code is governed by a BSD-style license that can be |
| +found in the LICENSE file. |
| +--> |
| +<!DOCTYPE html> |
| +<html> |
| +<head> |
| +<meta charset="utf-8"> |
| +<if expr="is_android or is_ios"> |
| +<meta name="viewport" content="width=device-width, initial-scale=1.0, |
| + maximum-scale=1.0, user-scalable=no"> |
| +</if> |
| +<title>Snippets Internals</title> |
| +<link rel="stylesheet" href="chrome://resources/css/text_defaults.css"> |
| +<link rel="stylesheet" href="snippets_internals.css"> |
| +<script src="chrome://resources/js/cr.js"></script> |
| +<script src="chrome://resources/js/jstemplate_compiled.js"></script> |
| +<script src="chrome://resources/js/util.js"></script> |
| +<script src="snippets_internals.js"></script> |
| +</head> |
| + |
| +<body> |
| +<div id="info"> |
| + <div class="section" jsskip="true"> |
| + <h2>Properties</h2> |
| + <table class="section-details"> |
| + <tr> |
| + <td class="name">Snippets enabled</td> |
| + <td id="flag-snippets" class="value"></td> |
| + </tr> |
| + <tr> |
| + <td class="name">Snippets restricted to hosts</td> |
| + <td id="switch-restrict-to-hosts" class="value"></td> |
| + </tr> |
| + </table> |
| + </div> |
| + |
| + <div id="snippets" class="section"> |
| + <h2>Snippets <span class="detail">(click for details)</span></h2> |
| + <table class="section-details"> |
| + <tr jsselect="list" style="display:none"> |
| + <td class="title-link"> |
| + <span class="snippet-title" jsvalues="myid:id"><span jscontent="title"></span> >></a> |
|
Marc Treib
2016/04/13 08:45:51
Line too long (a few more of those below too).
Als
jkrcal
2016/04/14 15:27:00
Done.
|
| + <div jsvalues="id:id" class="snippet-detail snippet-hidden"> |
| + <table> |
| + <tr> |
| + <td>Validity |
|
Marc Treib
2016/04/13 08:45:51
<td> tags should be closed.
jkrcal
2016/04/14 15:26:59
Not in HTML5.
https://www.w3.org/TR/2014/REC-html
Marc Treib
2016/04/14 15:43:44
Huh, today I learned!
But then please be consisten
|
| + <td class="expiry"> |
| + <span class="date" jscontent="published"></span> – |
| + <span class="date" jscontent="expires"></span> |
| + <tr> |
| + <td>Site title |
| + <td jscontent="siteTitle"> |
| + <tr> |
| + <td>Text |
| + <td jscontent="snippet"> |
| + <tr> |
| + <td>URL |
| + <td><a class="url" jsvalues="href:url" jscontent="url"></a> |
| + <tr> |
| + <td>Favicon |
| + <td><a class="url" jsvalues="href:faviconUrl" jscontent="faviconUrl"></a> |
| + <tr> |
| + <td>Salient image |
| + <td><a class="url" jsvalues="href:salientImageUrl" jscontent="salientImageUrl"></a> |
| + </table> |
| + </div> |
| + </td> |
| + </tr> |
| + </table> |
| + <div class="detail" id="snippets-empty" jsskip="1"></div> |
| + <div class="forms" jsskip="1"> |
| + <input id="submit-clear" type="submit" value="Clear the list"> |
| + </div> |
| + <div class="forms" jsskip="1"> |
| + <input id="submit-download" type="submit" value="Add snippets"> |
| + from hosts <input id="hosts-input" type="text"> |
| + <div class="detail"> |
| + e.g. "www.wired.com www.bbc.co.uk", |
| + <span id="hosts-help"></span>. |
| + </div> |
| + </div> |
| + </div> |
| + |
| + <div id="discarded-snippets" class="section"> |
| + <h2>Discarded snippets <span class="detail">(click for details)</span></h2> |
| + <table class="section-details"> |
| + <tr jsselect="list" style="display:none"> |
| + <td class="title-link"> |
| + <span class="discarded-snippet-title" jsvalues="myid:id"><span jscontent="title"></span> >></a> |
|
Marc Treib
2016/04/13 08:45:51
">></a>" ?
jkrcal
2016/04/14 15:26:59
Done.
|
| + <div jsvalues="id:id" class="snippet-detail snippet-hidden"> |
| + <table> |
| + <tr> |
| + <td>Validity |
| + <td class="expiry"> |
| + <span class="date" jscontent="published"></span> – |
| + <span class="date" jscontent="expires"></span> |
| + <tr> |
| + <td>Text |
| + <td jscontent="snippet"> |
| + <tr> |
| + <td>URL |
| + <td><a class="url" jsvalues="href:url" jscontent="url"></a> |
| + <tr> |
| + <td>Favicon |
| + <td><a class="url" jsvalues="href:faviconUrl" jscontent="faviconUrl"></a> |
| + <tr> |
| + <td>Salient image |
| + <td><a class="url" jsvalues="href:salientImageUrl" jscontent="salientImageUrl"></a> |
| + </table> |
| + </div> |
| + </td> |
| + </tr> |
| + </table> |
| + <div class="detail" id="discarded-snippets-empty" jsskip="1"></div> |
| + <div class="forms" jsskip="1"> |
| + <input id="discarded-snippets-clear" type="submit" value="Clear list"> |
| + </div> |
| + </div> |
| + |
| + <div id="hosts" class="section"> |
| + <h2>Suggestion hosts</h2> |
| + <table class="section-details"> |
| + <tr jsselect="list"> |
| + <td jscontent="url"></td> |
| + </tr> |
| + </table> |
| + <div class="detail" id="hosts-empty" jsskip="1"></div> |
| + </div> |
| +</div> |
| + |
| +</body> |
| +</html> |
| + |
