chrome://snippets-internals page for debugging NTP snippets.

components/ntp_snippets/ntp_snippets_service_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/json/json_reader.h"
 #include "base/macros.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/thread_task_runner_handle.h"
@@ skipping 149 matching lines @@
     EXPECT_EQ(snippet.title(), "Title");
     EXPECT_EQ(snippet.snippet(), "Snippet");
     EXPECT_EQ(snippet.salient_image_url(),
               GURL("http://localhost/salient_image"));
     base::Time then =
         base::Time::FromUTCExploded({2015, 11, 4, 25, 13, 46, 45});
     EXPECT_EQ(then, snippet.publish_date());
   }
 }
 
+TEST_F(NTPSnippetsServiceTest, Clear) {
+  std::string json_str(GetTestJson(1448459205));
+
+  ASSERT_TRUE(LoadFromJSONString(json_str));

[Marc Treib, 2016/04/13 08:45:52]

Heads-up: I changed the setup of these tests slightly in
https://codereview.chromium.org/1878993002/, you'll have to rebase. (e.g.
LoadFromJSONString doesn't have a return value anymore)

[jkrcal, 2016/04/14 15:27:01]

Done.

+  EXPECT_EQ(service()->size(), 1u);
+
+  service()->ClearSnippets();
+  EXPECT_EQ(service()->size(), 0u);
+}
+
 TEST_F(NTPSnippetsServiceTest, Discard) {
   std::string json_str(
       "{ \"recos\": [ { \"contentInfo\": { \"url\" : \"http://site.com\" }}]}");
   ASSERT_TRUE(LoadFromJSONString(json_str));
 
   ASSERT_EQ(1u, service()->size());
 
   // Discarding a non-existent snippet shouldn't do anything.
   EXPECT_FALSE(service()->DiscardSnippet(GURL("http://othersite.com")));
   EXPECT_EQ(1u, service()->size());
 
   // Discard the snippet.
   EXPECT_TRUE(service()->DiscardSnippet(GURL("http://site.com")));
   EXPECT_EQ(0u, service()->size());
 
   // Make sure that fetching the same snippet again does not re-add it.
   ASSERT_TRUE(LoadFromJSONString(json_str));
   EXPECT_EQ(0u, service()->size());
 
   // The snippet should stay discarded even after re-creating the service.
   CreateSnippetsService();
   // Init the service, so the prefs get loaded.
   // TODO(treib): This should happen in CreateSnippetsService.
   service()->Init(true);
   ASSERT_TRUE(LoadFromJSONString(json_str));
   EXPECT_EQ(0u, service()->size());
+
+  // The snippet can be added again after clearing discarded snippets.
+  service()->ClearDiscardedSnippets();
+  EXPECT_EQ(0u, service()->size());
+  ASSERT_TRUE(LoadFromJSONString(json_str));
+  EXPECT_EQ(1u, service()->size());
+}
+
+TEST_F(NTPSnippetsServiceTest, GetDiscarded) {
+  std::string json_str(
+      "{ \"recos\": [ { \"contentInfo\": { \"url\" : \"http://site.com\" }}]}");
+  ASSERT_TRUE(LoadFromJSONString(json_str));
+
+  // For the test, we need the snippet to get discarded.
+  ASSERT_TRUE(service()->DiscardSnippet(GURL("http://site.com")));
+  const NTPSnippetsService::NTPSnippetStorage& snippets =
+      service()->GetDiscardedSnippets();
+  EXPECT_EQ(1u, snippets.size());
+  for (auto& snippet : snippets) {
+    EXPECT_EQ(GURL("http://site.com"), snippet->url());
+  }
+
+  // There should be no discarded snippet after clearing the list.
+  service()->ClearDiscardedSnippets();
+  EXPECT_EQ(0u, snippets.size());

[Marc Treib, 2016/04/13 08:45:52]

Ah, this works because you have a reference to the member, which changed in the
meantime... I find this kinda surprising/hard to read, I'd prefer to say
service()->GetDiscardedSnippets().size() here.

[jkrcal, 2016/04/14 15:27:01]

Done.

 }
 
 TEST_F(NTPSnippetsServiceTest, CreationTimestampParseFail) {
   std::string json_str(GetTestJson("aaa1448459205"));
 
   ASSERT_TRUE(LoadFromJSONString(json_str));
   EXPECT_EQ(service()->size(), 1u);
 
   // The same for loop without the '&' should not compile.
   for (auto& snippet : *service()) {
     // Snippet here is a const.
     EXPECT_EQ(snippet.url(), GURL("http://localhost/foobar"));
     EXPECT_EQ(snippet.title(), "Title");
     EXPECT_EQ(snippet.snippet(), "Snippet");
     EXPECT_EQ(base::Time::UnixEpoch(), snippet.publish_date());
   }
 }
 
 TEST_F(NTPSnippetsServiceTest, RemoveExpiredContent) {
   std::string json_str(GetTestExpiredJson(1448459205));
 
   ASSERT_TRUE(LoadFromJSONString(json_str));
   EXPECT_EQ(service()->size(), 0u);
 }
 
 }  // namespace ntp_snippets