chrome://snippets-internals page for debugging NTP snippets.

components/ntp_snippets/ntp_snippets_service.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NTP_SNIPPETS_NTP_SNIPPETS_SERVICE_H_
 #define COMPONENTS_NTP_SNIPPETS_NTP_SNIPPETS_SERVICE_H_
 
 #include <stddef.h>
 
 #include <set>
@@ skipping 57 matching lines @@
 
   static void RegisterProfilePrefs(PrefRegistrySimple* registry);
 
   void Init(bool enabled);
 
   // Inherited from KeyedService.
   void Shutdown() override;
 
   // Fetches snippets from the server and adds them to the current ones.
   void FetchSnippets();
+  // Fetches snippets from the server for specified hosts (overriding
+  // suggestions from the suggestion service) and adds them to the current ones.
+  void FetchSnippetsFromHosts(const std::set<std::string>& hosts);
+  // Deletes all currently stored snippets.

[Bernhard Bauer, 2016/04/14 16:50:24]

Empty line before comment.

[jkrcal, 2016/04/15 14:11:50]

Done.

+  void ClearSnippets();
 
   // Discards the snippet with the given |url|, if it exists. Returns true iff
   // a snippet was discarded.
   bool DiscardSnippet(const GURL& url);
 
+  // Returns the lists of snippets previously discarded by the user (that are
+  // not expired yet).
+  const NTPSnippetStorage& discarded_snippets() const {

[Bernhard Bauer, 2016/04/14 16:50:24]

Somewhat unrelated yak-shaving: Now that we have an accessor for discarded
snippets, I personally would like to put the non-discarded snippets behind an
accessor as well (both for symmetry, and because I've always thought it was a
bit weird to directly iterate over this server).

[Marc Treib, 2016/04/15 09:00:30]

+1, but IMO this can wait for another CL.

[jkrcal, 2016/04/15 14:11:50]

I agree, I really did not like the asymmetry when writing the code.
Can it wait for another CL?

+    return discarded_snippets_;
+  }
+
+  // Clears the lists of snippets previously discarded by the user.
+  void ClearDiscardedSnippets();
+
+  // Returns the lists of suggestion hosts the snippets are restricted to.
+  std::set<std::string> GetSuggestionsHosts() const;
+
   // Observer accessors.
   void AddObserver(NTPSnippetsServiceObserver* observer);
   void RemoveObserver(NTPSnippetsServiceObserver* observer);
 
   // Number of snippets available.
   size_t size() const { return snippets_.size(); }
 
   // The snippets can be iterated upon only via a const_iterator. Recommended
   // way to iterate is as follows:
   //
   // NTPSnippetsService* service; // Assume is set.
   //  for (auto& snippet : *service) {
   //    // |snippet| here is a const object.
   //  }
   const_iterator begin() const { return const_iterator(snippets_.begin()); }
   const_iterator end() const { return const_iterator(snippets_.end()); }
 
  private:
   friend class NTPSnippetsServiceTest;
 
   void OnSuggestionsChanged(const suggestions::SuggestionsProfile& suggestions);
   void OnSnippetsDownloaded(const std::string& snippets_json);
 
   void OnJsonParsed(const std::string& snippets_json,
                     scoped_ptr<base::Value> parsed);
   void OnJsonError(const std::string& snippets_json, const std::string& error);
 
-  void FetchSnippetsImpl(const std::set<std::string>& hosts);
-
   // Expects a top-level dictionary containing a "recos" list, which will be
   // passed to LoadFromListValue().
   bool LoadFromValue(const base::Value& value);
 
   // Expects a list of dictionaries each containing a "contentInfo" dictionary
   // with keys matching the properties of a snippet (url, title, site_title,
   // etc...). The URL is the only mandatory value.
   bool LoadFromListValue(const base::ListValue& list);
 
   // TODO(treib): Investigate a better storage, maybe LevelDB or SQLite?
@@ skipping 64 matching lines @@
   // Sent when the service is shutting down.
   virtual void NTPSnippetsServiceShutdown() = 0;
 
  protected:
   virtual ~NTPSnippetsServiceObserver() {}
 };
 
 }  // namespace ntp_snippets
 
 #endif  // COMPONENTS_NTP_SNIPPETS_NTP_SNIPPETS_SERVICE_H_