chrome/browser/resources/snippets_internals.html - Issue 1883523002: chrome://snippets-internals page for debugging NTP snippets.

Side by Side Diff: chrome/browser/resources/snippets_internals.html

Issue 1883523002: chrome://snippets-internals page for debugging NTP snippets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding the chrome://snippets-internals page in the auto-suggest list. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/snippets_internals.css ('K') | « chrome/browser/resources/snippets_internals.css ('k') | chrome/browser/resources/snippets_internals.js » ('j') | chrome/browser/resources/snippets_internals.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!--

	2 Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file.

	5 -->

	6 <!DOCTYPE html>

	7 <html>

	8 <head>

	9 <meta charset="utf-8">

	10 <if expr="is_android or is_ios">

	11 <meta name="viewport" content="width=device-width, initial-scale=1.0,

	12 maximum-scale=1.0, user-scalable=no">
	Bernhard Bauer 2016/04/14 16:50:24 Indent this line four spaces. Indent this line four spaces. jkrcal 2016/04/15 14:11:50 Done. Show quoted text On 2016/04/14 16:50:24, Bernhard (OOO until Apr 18) wrote: > Indent this line four spaces. Done.
	13 </if>

	14 <title>Snippets Internals</title>

	15 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">

	16 <link rel="stylesheet" href="snippets_internals.css">

	17 <script src="chrome://resources/js/cr.js"></script>

	18 <script src="chrome://resources/js/jstemplate_compiled.js"></script>

	19 <script src="chrome://resources/js/util.js"></script>

	20 <script src="snippets_internals.js"></script>

	21 </head>

	22

	23 <body>

	24 <div id="info">

	25 <div class="section" jsskip="true">
	Bernhard Bauer 2016/04/14 16:50:24 What's the jsskip for? What's the jsskip for? jkrcal 2016/04/15 14:11:50 It informs the jstemplate library that it can skip Show quoted text On 2016/04/14 16:50:24, Bernhard (OOO until Apr 18) wrote: > What's the jsskip for? It informs the jstemplate library that it can skip this element with its whole subtree while scanning the DOM tree. (an optimization that is unnecessary with this file size but I'd like to keep it for the matter of consistency across the code base) Bernhard Bauer 2016/04/18 14:01:34 Eh, it strikes me a bit as premature optimization Show quoted text On 2016/04/15 14:11:50, jkrcal wrote: > On 2016/04/14 16:50:24, Bernhard (OOO until Apr 18) wrote: > > What's the jsskip for? > > It informs the jstemplate library that it can skip this element with its whole > subtree while scanning the DOM tree. > (an optimization that is unnecessary with this file size but I'd like to keep > it for the matter of consistency across the code base) Eh, it strikes me a bit as premature optimization :) jkrcal 2016/04/18 15:02:06 Done (removed). Show quoted text On 2016/04/18 14:01:34, Bernhard Bauer wrote: > On 2016/04/15 14:11:50, jkrcal wrote: > > On 2016/04/14 16:50:24, Bernhard (OOO until Apr 18) wrote: > > > What's the jsskip for? > > > > It informs the jstemplate library that it can skip this element with its whole > > subtree while scanning the DOM tree. > > (an optimization that is unnecessary with this file size but I'd like to keep > > it for the matter of consistency across the code base) > > Eh, it strikes me a bit as premature optimization :) Done (removed).
	26 <h2>Properties</h2>

	27 <table class="section-details">

	28 <tr>

	29 <td class="name">Snippets enabled</td>

	30 <td id="flag-snippets" class="value"></td>

	31 </tr>

	32 <tr>

	33 <td class="name">Snippets restricted to hosts</td>

	34 <td id="switch-restrict-to-hosts" class="value"></td>

	35 </tr>

	36 </table>

	37 </div>

	38

	39 <div id="snippets" class="section">

	40 <h2>Snippets <span class="detail">(click for details)</span></h2>

	41 <table class="section-details">

	42 <tr jsselect="list" style="display:none">

	43 <td class="title-link">

	44 <span class="snippet-title" jsvalues="myid:id">
	Bernhard Bauer 2016/04/14 16:50:24 "myid" is not very meaningful. "snippet-id" maybe? "myid" is not very meaningful. "snippet-id" maybe? jkrcal 2016/04/15 14:11:50 Done. Show quoted text On 2016/04/14 16:50:24, Bernhard (OOO until Apr 18) wrote: > "myid" is not very meaningful. "snippet-id" maybe? Done.
	45 <span jscontent="title"></span>

	46 >>

	47 </span>

	48 <div jsvalues="id:id" class="snippet-detail snippet-hidden">

	49 <table>

	50 <tr>

	51 <td>Validity

	52 <td class="expiry">

	53 <span class="date" jscontent="published"></span> –

	54 <span class="date" jscontent="expires"></span>

	55 <tr>

	56 <td>Site title

	57 <td jscontent="siteTitle">

	58 <tr>

	59 <td>Text

	60 <td jscontent="snippet">

	61 <tr>

	62 <td>URL

	63 <td><a class="url" jsvalues="href:url" jscontent="url"></a>

	64 <tr>

	65 <td>Favicon

	66 <td>

	67 <a class="url" jsvalues="href:faviconUrl"

	68 jscontent="faviconUrl"></a>
	Bernhard Bauer 2016/04/14 16:50:24 This should be indented four spaces. This should be indented four spaces. jkrcal 2016/04/15 14:11:50 Done. Show quoted text On 2016/04/14 16:50:24, Bernhard (OOO until Apr 18) wrote: > This should be indented four spaces. Done.
	69 <tr>

	70 <td>Salient image

	71 <td>

	72 <a class="url" jsvalues="href:salientImageUrl"
	Bernhard Bauer 2016/04/14 16:50:24 Would it make more sense to show the image inline? Would it make more sense to show the image inline? jkrcal 2016/04/15 14:11:50 I think for debugging it is more important to see Show quoted text On 2016/04/14 16:50:24, Bernhard (OOO until Apr 18) wrote: > Would it make more sense to show the image inline? I think for debugging it is more important to see the URL. If you want to check that for a particular snippet, the image exists, you can always click the link. I'd prefer to tune it after users' feedback.
	73 jscontent="salientImageUrl"></a>

	74 </table>

	75 </div>

	76 </td>

	77 </tr>

	78 </table>

	79 <div class="detail" id="snippets-empty" jsskip="1"></div>

	80 <div class="forms" jsskip="1">

	81 <input id="submit-clear" type="submit" value="Clear the list">

	82 </div>

	83 <div class="forms" jsskip="1">

	84 <input id="submit-download" type="submit" value="Add snippets">

	85 from hosts <input id="hosts-input" type="text">

	86 <div class="detail">

	87 e.g. "www.wired.com www.bbc.co.uk",
	Bernhard Bauer 2016/04/14 16:50:24 You could make this a hint text (placeholder="..." You could make this a hint text (placeholder="...") on the input field. jkrcal 2016/04/15 14:11:50 Done. Show quoted text On 2016/04/14 16:50:24, Bernhard (OOO until Apr 18) wrote: > You could make this a hint text (placeholder="...") on the input field. Done.
	88 <span id="hosts-help"></span>.

	89 </div>

	90 </div>

	91 </div>

	92

	93 <div id="discarded-snippets" class="section">
	Bernhard Bauer 2016/04/14 16:50:24 This is another disadvantage of having discarded s This is another disadvantage of having discarded snippets separate: the template for these is duplicated. Could we somehow process these with the same template? (Generally, this would also strike me as a good use case for Polymer, but that would obviously be a bigger change.) jkrcal 2016/04/15 14:11:50 I was not aware of Polymer, just used the same lib Show quoted text On 2016/04/14 16:50:24, Bernhard (OOO until Apr 18) wrote: > This is another disadvantage of having discarded snippets separate: the template > for these is duplicated. Could we somehow process these with the same template? > > (Generally, this would also strike me as a good use case for Polymer, but that > would obviously be a bigger change.) I was not aware of Polymer, just used the same library that has been used in a similar internals page. I am not aware of a way how to have just one html template here with jstemplate. Even though it is quite a pain to keep the two places consistent (and constantly forget about some change), I would prefer to keep it as it is for this CL. I am also fine with switching to Polymer as an additional exercise in an additional CL. Do you think it is worth it? Marc Treib 2016/04/15 15:51:32 Nah, IMO it's not worth switching. Maybe the next Show quoted text On 2016/04/15 14:11:50, jkrcal wrote: > On 2016/04/14 16:50:24, Bernhard (OOO until Apr 18) wrote: > > This is another disadvantage of having discarded snippets separate: the > template > > for these is duplicated. Could we somehow process these with the same > template? > > > > (Generally, this would also strike me as a good use case for Polymer, but that > > would obviously be a bigger change.) > > I was not aware of Polymer, just used the same library that has been used in a > similar internals page. > I am not aware of a way how to have just one html template here with jstemplate. > > Even though it is quite a pain to keep the two places consistent (and constantly > forget about some change), I would prefer to keep it as it is for this CL. > > I am also fine with switching to Polymer as an additional exercise in an > additional CL. Do you think it is worth it? Nah, IMO it's not worth switching. Maybe the next time we create an internals page, we could do it using Polymer from the beginning. (Caveat: I have never used Polymer, so I basically have no idea what I'm talking about here :D)
	94 <h2>Discarded snippets <span class="detail">(click for details)</span></h2>

	95 <table class="section-details">

	96 <tr jsselect="list" style="display:none">

	97 <td class="title-link">

	98 <span class="discarded-snippet-title" jsvalues="myid:id">

	99 <span jscontent="title"></span>

	100 >>

	101 </span>

	102 <div jsvalues="id:id" class="snippet-detail snippet-hidden">

	103 <table>

	104 <tr>

	105 <td>Validity

	106 <td class="expiry">

	107 <span class="date" jscontent="published"></span> –

	108 <span class="date" jscontent="expires"></span>

	109 <tr>

	110 <td>Text

	111 <td jscontent="snippet">

	112 <tr>

	113 <td>URL

	114 <td><a class="url" jsvalues="href:url" jscontent="url"></a>

	115 <tr>

	116 <td>Favicon

	117 <td>

	118 <a class="url" jsvalues="href:faviconUrl"

	119 jscontent="faviconUrl"></a>
	Bernhard Bauer 2016/04/18 14:01:34 This should be indented four more spaces (it's par This should be indented four more spaces (it's part of the opening <a>). jkrcal 2016/04/18 15:02:06 This is not the last version of the file, it has c Show quoted text On 2016/04/18 14:01:34, Bernhard Bauer wrote: > This should be indented four more spaces (it's part of the opening <a>). This is not the last version of the file, it has changed since (and has proper spacing).
	120 <tr>

	121 <td>Salient image

	122 <td>

	123 <a class="url" jsvalues="href:salientImageUrl"

	124 jscontent="salientImageUrl"></a>

	125 </table>

	126 </div>

	127 </td>

	128 </tr>

	129 </table>

	130 <div class="detail" id="discarded-snippets-empty" jsskip="1"></div>

	131 <div class="forms" jsskip="1">

	132 <input id="discarded-snippets-clear" type="submit" value="Clear list">

	133 </div>

	134 </div>

	135

	136 <div id="hosts" class="section">

	137 <h2>Suggestion hosts</h2>

	138 <table class="section-details">

	139 <tr jsselect="list">

	140 <td jscontent="url"></td>

	141 </tr>

	142 </table>

	143 <div class="detail" id="hosts-empty" jsskip="1"></div>

	144 </div>

	145 </div>

	146

	147 </body>

	148 </html>

	149

OLD	NEW