Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1883513004: Revert "Revert "Fix handling of cross-origin windows in dartium and better align general handling o… (Closed)

Created:
4 years, 8 months ago by Jacob
Modified:
4 years, 8 months ago
Reviewers:
terry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Revert "Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects."" Fix missing case that was breaking co19 tests. This reverts commit 688eeb555c9e2b93e38a18a02c78aee85b9d9665. BUG= Committed: https://github.com/dart-lang/sdk/commit/08c171d3e5a876fc99200c496ed16d4cd921095f

Patch Set 1 #

Patch Set 2 : baseline #

Patch Set 3 : fix bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -144 lines) Patch
M sdk/lib/_blink/dartium/_blink_dartium.dart View 1 chunk +0 lines, -33 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 2 21 chunks +85 lines, -45 lines 0 comments Download
M sdk/lib/html/html_common/conversions_dartium.dart View 1 chunk +9 lines, -3 lines 0 comments Download
M tools/dom/scripts/generate_blink_file.py View 1 chunk +0 lines, -33 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 1 2 3 chunks +35 lines, -24 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 2 chunks +34 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jacob
TBR
4 years, 8 months ago (2016-04-13 00:12:23 UTC) #2
Jacob
TBR
4 years, 8 months ago (2016-04-13 00:12:24 UTC) #4
Jacob
4 years, 8 months ago (2016-04-13 00:16:11 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
08c171d3e5a876fc99200c496ed16d4cd921095f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698