Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 18835002: DevTools extensions: forward keyboard shortcuts to DevTools (Closed)

Created:
7 years, 5 months ago by caseq
Modified:
7 years, 5 months ago
Reviewers:
apavlov, vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools extensions: forward keyboard shortcuts to DevTools This adds keyboard event handler that forwards keyboard extensions that look like shortcuts to DevTools, so these may be handled as global shortcuts by DevTools. BUG=160930 R=apavlov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153786

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -1 line) Patch
M LayoutTests/inspector/extensions/extensions-panel.html View 2 chunks +49 lines, -0 lines 0 comments Download
M LayoutTests/inspector/extensions/extensions-panel-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/ExtensionAPI.js View 1 2 chunks +22 lines, -0 lines 0 comments Download
M Source/devtools/front_end/ExtensionServer.js View 1 2 chunks +20 lines, -0 lines 0 comments Download
M Source/devtools/front_end/externs.js View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/devtools/front_end/inspector.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
apavlov
LGTM with nits https://codereview.chromium.org/18835002/diff/1/Source/devtools/front_end/ExtensionAPI.js File Source/devtools/front_end/ExtensionAPI.js (right): https://codereview.chromium.org/18835002/diff/1/Source/devtools/front_end/ExtensionAPI.js#newcode732 Source/devtools/front_end/ExtensionAPI.js:732: if (!event.ctrlKey && !event.altKey && !event.metaKey ...
7 years, 5 months ago (2013-07-09 06:51:58 UTC) #1
caseq
7 years, 5 months ago (2013-07-09 14:23:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r153786 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698