[OnionSoup] Moving WakeLock Service to Blink (2/2): removing WebWakeLockClient and WakeLockDispatch…

third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/wake_lock/ScreenWakeLock.h"
 
 #include "core/frame/LocalFrame.h"
 #include "core/frame/Screen.h"
 #include "core/page/PageVisibilityState.h"
 #include "platform/RuntimeEnabledFeatures.h"
-#include "public/platform/modules/wake_lock/WebWakeLockClient.h"
+#include "public/platform/ServiceRegistry.h"
 
 namespace blink {
 
 // static
 bool ScreenWakeLock::keepAwake(Screen& screen)
 {
     ScreenWakeLock* screenWakeLock = fromScreen(screen);
     if (!screenWakeLock)
         return false;
 
     return screenWakeLock->keepAwake();
 }
 
 // static
 void ScreenWakeLock::setKeepAwake(Screen& screen, bool keepAwake)
 {
     ScreenWakeLock* screenWakeLock = fromScreen(screen);
-    if (!screenWakeLock)
-        return;
-
-    screenWakeLock->setKeepAwake(keepAwake);
-}
-
-void ScreenWakeLock::setKeepAwake(bool keepAwake)
-{
-    m_keepAwake = keepAwake;
-    notifyClient();
+    if (screenWakeLock)
+        screenWakeLock->setKeepAwake(keepAwake);
 }
 
 // static
 const char* ScreenWakeLock::supplementName()
 {
     return "ScreenWakeLock";
 }
 
 // static
 ScreenWakeLock* ScreenWakeLock::from(LocalFrame* frame)
 {
     return static_cast<ScreenWakeLock*>(Supplement<LocalFrame>::from(frame, supplementName()));
 }
 
 // static
-void ScreenWakeLock::provideTo(LocalFrame& frame, WebWakeLockClient* client)
+void ScreenWakeLock::provideTo(LocalFrame& frame, ServiceRegistry* registry)
 {
-    ASSERT(RuntimeEnabledFeatures::wakeLockEnabled());
+    DCHECK(RuntimeEnabledFeatures::wakeLockEnabled());
     Supplement<LocalFrame>::provideTo(
         frame,
         ScreenWakeLock::supplementName(),
-        new ScreenWakeLock(frame, client));
+        registry ? new ScreenWakeLock(frame, registry) : nullptr);

[esprehn, 2016/04/15 22:38:13]

hmm, why would you ever get a null registry?

[mcasas, 2016/04/16 00:34:14]

See below.

 }
 
 void ScreenWakeLock::pageVisibilityChanged()
 {
     notifyClient();
 }
 
 void ScreenWakeLock::didCommitLoad(LocalFrame* committedFrame)
 {
     // Reset wake lock flag for this frame if it is the one being navigated.
-    if (committedFrame == frame()) {
+    if (committedFrame == frame())
         setKeepAwake(false);
-    }
 }
 
 void ScreenWakeLock::willDetachFrameHost()
 {
-    m_client = nullptr;
+    setKeepAwake(false);
 }
 
 DEFINE_TRACE(ScreenWakeLock)
 {
     Supplement<LocalFrame>::trace(visitor);
     PageLifecycleObserver::trace(visitor);
     LocalFrameLifecycleObserver::trace(visitor);
 }
 
-ScreenWakeLock::ScreenWakeLock(LocalFrame& frame, WebWakeLockClient* client)
+ScreenWakeLock::ScreenWakeLock(LocalFrame& frame, ServiceRegistry* registry)

[esprehn, 2016/04/15 22:38:13]

pass a reference

[mcasas, 2016/04/16 00:34:14]

See below.

     : PageLifecycleObserver(frame.page())
     , LocalFrameLifecycleObserver(&frame)
-    , m_client(client)
     , m_keepAwake(false)
 {
+    DCHECK(!m_service.is_bound());
+    DCHECK(registry);

[esprehn, 2016/04/15 22:38:13]

remove dcheck and just use a reference?

[mcasas, 2016/04/16 00:34:14]

ServiceRegistry should not be null, but the caller
to Create() pull it out of |m_client| and that can be
nullptr [1]. See the patterns like:

    if (RuntimeEnabledFeatures::wakeLockEnabled())
        ScreenWakeLock::provideTo(*m_frame, m_client ?
m_client->serviceRegistry(): nullptr);

in there.

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

+    registry->connectToRemoteService(mojo::GetProxy(&m_service));
+}
+
+bool ScreenWakeLock::keepAwake() const
+{
+    return m_keepAwake;
+}
+
+void ScreenWakeLock::setKeepAwake(bool keepAwake)
+{
+    m_keepAwake = keepAwake;
+    notifyClient();
 }
 
 // static
 ScreenWakeLock* ScreenWakeLock::fromScreen(Screen& screen)
 {
     return screen.frame() ? ScreenWakeLock::from(screen.frame()) : nullptr;
 }
 
 void ScreenWakeLock::notifyClient()

[esprehn, 2016/04/15 22:38:13]

does this need a new name?

[mcasas, 2016/04/16 00:34:14]

Done.

 {
-    if (!m_client)
+    if (!m_service)
         return;
 
-    m_client->requestKeepScreenAwake(m_keepAwake && page() && page()->isPageVisible());
+    if (m_keepAwake && frame()->page() && frame()->page()->isPageVisible())
+        m_service->RequestWakeLock();
+    else
+        m_service->CancelWakeLock();
 }
 
 } // namespace blink