Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: third_party/WebKit/Source/core/dom/Document.idl

Issue 1883433003: Add UseCounter for legacy document.* that returns HTMLCollection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Document.idl
diff --git a/third_party/WebKit/Source/core/dom/Document.idl b/third_party/WebKit/Source/core/dom/Document.idl
index b9ee23108dc5d5e0e81f825951992d97d3f9f648..6ddc0c09e1db138606c60d96fa96a1cce161d305 100644
--- a/third_party/WebKit/Source/core/dom/Document.idl
+++ b/third_party/WebKit/Source/core/dom/Document.idl
@@ -103,12 +103,12 @@ interface Document : Node {
[CustomElementCallbacks] attribute DOMString dir;
[RaisesException=Setter, CustomElementCallbacks, PerWorldBindings] attribute HTMLElement? body;
readonly attribute HTMLHeadElement? head;
- [SameObject] readonly attribute HTMLCollection images;
- [SameObject] readonly attribute HTMLCollection embeds;
- [SameObject, ImplementedAs=embeds] readonly attribute HTMLCollection plugins;
- [SameObject] readonly attribute HTMLCollection links;
- [SameObject] readonly attribute HTMLCollection forms;
- [SameObject] readonly attribute HTMLCollection scripts;
+ [SameObject, MeasureAs=DocumentImages] readonly attribute HTMLCollection images;
philipj_slow 2016/04/12 09:51:57 Can you use just [Measure] to get the generated na
kochi 2016/04/12 10:10:53 Good to know. Changed to use [Measure] and renamed
+ [SameObject, MeasureAs=DocumentEmbeds] readonly attribute HTMLCollection embeds;
+ [SameObject, ImplementedAs=embeds, MeasureAs=DocumentPlugins] readonly attribute HTMLCollection plugins;
+ [SameObject, MeasureAs=DocumentLinks] readonly attribute HTMLCollection links;
+ [SameObject, MeasureAs=DocumentForms] readonly attribute HTMLCollection forms;
+ [SameObject, MeasureAs=DocumentScripts] readonly attribute HTMLCollection scripts;
[PerWorldBindings] NodeList getElementsByName(DOMString elementName);
[ImplementedAs=currentScriptForBinding] readonly attribute HTMLScriptElement? currentScript;
@@ -137,8 +137,8 @@ interface Document : Node {
// FIXME: *Color are on HTMLDocument.
- readonly attribute HTMLCollection anchors;
- readonly attribute HTMLCollection applets;
+ [MeasureAs=DocumentAnchors] readonly attribute HTMLCollection anchors;
+ [MeasureAs=DocumentApplets] readonly attribute HTMLCollection applets;
// FIXME: clear(), captureEvents(), releaseEvents() and all are on HTMLDocument.
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698