Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1883433003: Add UseCounter for legacy document.* that returns HTMLCollection. (Closed)

Created:
4 years, 8 months ago by kochi
Modified:
4 years, 8 months ago
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, asvitkine+watch_chromium.org, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UseCounter for legacy document.* that returns HTMLCollection. Add counter for - document.images - document.embeds - document.plugins - document.links - document.forms - document.scripts - document.anchors - document.applets BUG=602575 Committed: https://crrev.com/d930173a3c06fa815d0994abf4c9e0dd497a4d19 Cr-Commit-Position: refs/heads/master@{#386810}

Patch Set 1 #

Total comments: 2

Patch Set 2 : use [Measure] #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M third_party/WebKit/Source/core/dom/Document.idl View 1 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
kochi
Philip, this adds use counter for document.applets (and other similar collection APIs as well). Either ...
4 years, 8 months ago (2016-04-12 09:19:01 UTC) #3
philipj_slow
lgtm % [Measure] Added isherman@ for histograms.xml https://codereview.chromium.org/1883433003/diff/1/third_party/WebKit/Source/core/dom/Document.idl File third_party/WebKit/Source/core/dom/Document.idl (right): https://codereview.chromium.org/1883433003/diff/1/third_party/WebKit/Source/core/dom/Document.idl#newcode106 third_party/WebKit/Source/core/dom/Document.idl:106: [SameObject, MeasureAs=DocumentImages] ...
4 years, 8 months ago (2016-04-12 09:51:58 UTC) #5
kochi
Thanks for the review. Updated the CL. isherman@, could you review for histograms.xml? https://codereview.chromium.org/1883433003/diff/1/third_party/WebKit/Source/core/dom/Document.idl File ...
4 years, 8 months ago (2016-04-12 10:10:53 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883433003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883433003/20001
4 years, 8 months ago (2016-04-12 10:11:09 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-12 11:31:52 UTC) #10
Ilya Sherman
histograms.xml lgtm
4 years, 8 months ago (2016-04-12 21:17:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883433003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883433003/20001
4 years, 8 months ago (2016-04-12 21:18:38 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-12 21:25:11 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 21:27:56 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d930173a3c06fa815d0994abf4c9e0dd497a4d19
Cr-Commit-Position: refs/heads/master@{#386810}

Powered by Google App Engine
This is Rietveld 408576698