[compiler] Move ensuring deoptimization support to backends.

[compiler] Move ensuring deoptimization support to backends.

This moves the responsibility of preparing full-codegen code with
deoptimization support into the backends. This avoids generating such
code when optimization can be done directly from existing bytecode.

R=bmeurer@chromium.org
BUG=v8:4280
LOG=n

Committed: https://crrev.com/62cca39e6cc4735e431978135e4ea40e3ded7094
Cr-Commit-Position: refs/heads/master@{#35517}

[Michael Starzinger, 2016-04-15 08:25:37]

Description was changed from

==========
[compiler] Move ensuring deoptimization support to backends.

This move the responsibility of preparing full-codegen code with support
for deoptimization into the backends. This avoids generating such code
when optimization can be done directly from existing bytecode.

R=
BUG=v8:4280
LOG=n
==========

to

==========
[compiler] Move ensuring deoptimization support to backends.

This moves the responsibility of preparing full-codegen code with
deoptimization support into the backends. This avoids generating such
code when optimization can be done directly from existing bytecode.

R=bmeurer@chromium.org
BUG=v8:4280
LOG=n
==========

[Michael Starzinger, 2016-04-15 08:25:37]

mstarzinger@chromium.org changed reviewers:
+ bmeurer@chromium.org, rmcilroy@chromium.org

[Michael Starzinger, 2016-04-15 08:29:06]

Benedikt: PTAL.
Ross: FYI.

[rmcilroy, 2016-04-15 10:11:17]

LGTM

https://codereview.chromium.org/1883403002/diff/40001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1883403002/diff/40001/src/objects.cc#newcode1...
src/objects.cc:13529: // bytecode as well as re-enabling optimization similar to
the above case.
Could we do this TODO as well? I think it makes sense to treat both Ignition and
FCG the same here.

[Benedikt Meurer, 2016-04-15 10:26:28]

lgtm

[Michael Starzinger, 2016-04-15 10:40:44]

Thanks! Addressed comments. Landing now-ish.

https://codereview.chromium.org/1883403002/diff/40001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1883403002/diff/40001/src/objects.cc#newcode1...
src/objects.cc:13529: // bytecode as well as re-enabling optimization similar to
the above case.
On 2016/04/15 10:11:17, rmcilroy wrote:
> Could we do this TODO as well? I think it makes sense to treat both Ignition
and
> FCG the same here.

Done.

[Michael Starzinger, 2016-04-15 11:22:26]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-04-15 11:22:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1883403002/#ps80001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2016-04-15 11:22:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1883403002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1883403002/80001

[commit-bot: I haz the power, 2016-04-15 11:24:55]

Description was changed from

==========
[compiler] Move ensuring deoptimization support to backends.

This moves the responsibility of preparing full-codegen code with
deoptimization support into the backends. This avoids generating such
code when optimization can be done directly from existing bytecode.

R=bmeurer@chromium.org
BUG=v8:4280
LOG=n
==========

to

==========
[compiler] Move ensuring deoptimization support to backends.

This moves the responsibility of preparing full-codegen code with
deoptimization support into the backends. This avoids generating such
code when optimization can be done directly from existing bytecode.

R=bmeurer@chromium.org
BUG=v8:4280
LOG=n
==========

[commit-bot: I haz the power, 2016-04-15 11:24:55]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-15 11:26:53]

Description was changed from

==========
[compiler] Move ensuring deoptimization support to backends.

This moves the responsibility of preparing full-codegen code with
deoptimization support into the backends. This avoids generating such
code when optimization can be done directly from existing bytecode.

R=bmeurer@chromium.org
BUG=v8:4280
LOG=n
==========

to

==========
[compiler] Move ensuring deoptimization support to backends.

This moves the responsibility of preparing full-codegen code with
deoptimization support into the backends. This avoids generating such
code when optimization can be done directly from existing bytecode.

R=bmeurer@chromium.org
BUG=v8:4280
LOG=n

Committed: https://crrev.com/62cca39e6cc4735e431978135e4ea40e3ded7094
Cr-Commit-Position: refs/heads/master@{#35517}
==========

[commit-bot: I haz the power, 2016-04-15 11:26:53]

Patchset 5 (id:??) landed as
https://crrev.com/62cca39e6cc4735e431978135e4ea40e3ded7094
Cr-Commit-Position: refs/heads/master@{#35517}