Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 1883373002: X87: [ia32] Byte and word memory operands in ia32 cmp/test. (Closed)

Created:
4 years, 8 months ago by zhengxing.li
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [ia32] Byte and word memory operands in ia32 cmp/test. port 3dd3beb06676fe8030d1fef9086cbe63e4a4376d (r35199) original commit message: Currently, if the size of two cmp or test operands is a byte or a word, we sign-extend or zero-extend each of them into a 32-bit register before doing the comparison, even when the conditions for the use of a memory operand are met. This CL makes it possible to load only one of them into a register and address the other as a memory operand. The tricky bit is that, unlike as in the x64 counterpart http://crrev.com/1780193003, not all registers can be accessed as bytes. BUG= Committed: https://crrev.com/39c39b54674561f1935cdd7088c3a880fb582ce4 Cr-Commit-Position: refs/heads/master@{#35508}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -53 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 2 chunks +41 lines, -30 lines 0 comments Download
M src/compiler/x87/instruction-codes-x87.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 5 chunks +74 lines, -22 lines 0 comments Download
M src/x87/assembler-x87.h View 2 chunks +12 lines, -1 line 0 comments Download
M src/x87/assembler-x87.cc View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 8 months ago (2016-04-15 06:42:11 UTC) #2
Weiliang
lgtm
4 years, 8 months ago (2016-04-15 06:43:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883373002/1
4 years, 8 months ago (2016-04-15 06:53:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 07:14:43 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 07:15:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39c39b54674561f1935cdd7088c3a880fb582ce4
Cr-Commit-Position: refs/heads/master@{#35508}

Powered by Google App Engine
This is Rietveld 408576698