Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1883343002: Finishing cras audio client unittest (Closed)

Created:
4 years, 8 months ago by Qiang(Joe) Xu
Modified:
4 years, 8 months ago
Reviewers:
jennyz
CC:
chromium-reviews, oshima+watch_chromium.org, hashimoto+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Finishing cras audio client unittest Combined with https://codereview.chromium.org/1885763004/ Testing on all method call of dbus APIs under cras::kCrasControlInterface, except GetVolumeState, which expects phasing out. BUG=598800 Committed: https://crrev.com/d587bb4ffd6c3ecbb4a7929c9bab0fed448f1c62 Cr-Commit-Position: refs/heads/master@{#387667}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -0 lines) Patch
M chromeos/dbus/cras_audio_client_unittest.cc View 2 chunks +217 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Qiang(Joe) Xu
4 years, 8 months ago (2016-04-15 01:35:36 UTC) #4
jennyz
lgtm
4 years, 8 months ago (2016-04-15 18:13:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883343002/1
4 years, 8 months ago (2016-04-15 18:21:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 19:03:04 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 19:04:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d587bb4ffd6c3ecbb4a7929c9bab0fed448f1c62
Cr-Commit-Position: refs/heads/master@{#387667}

Powered by Google App Engine
This is Rietveld 408576698