Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 188333003: Land Recent QUIC Changes. (Closed)

Created:
6 years, 9 months ago by ramant (doing other things)
Modified:
6 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Land Recent QUIC Changes. Refactor of QUIC's rtt storage and calculation to have a single RttStats object used by the SentPacketManager, LossDetectionAlgorithms, and SendAlgorithms. Merge internal change: 62624956 https://codereview.chromium.org/185053006/ QUIC refactor to move the pending_crypto_packet_count_ from the QuicSentPacketManager to the QuicUnackedPacketMap. Merge internal change: 62614116 https://codereview.chromium.org/188273003/ QUIC - Fix the spelling error in "frame received." message. Merge internal change: 62491376 https://codereview.chromium.org/188173003/ Doing a best-effort attempt to send connection close packet for open quic connection before we call exit(). The actual sending of the connection close is flag protected, though worst case we'd crash right before exit() anyway. Merge internal change: 62484710 https://codereview.chromium.org/180953008/ Test only change to QUIC TCPLossAlgorithmTest to ensure the early retransmit alarms is set for the earliest outstanding packet. Merge internal change: 62438180 https://codereview.chromium.org/188153003/ CL generated with data from dead-code analysis using Scythe remove_dead_code tool. Cleanup of net/quic using Scythe Merge internal change: 62404986 https://codereview.chromium.org/183683025/ Allow fixed (non-negotiated) values to be sent in QUIC CHLO/SHLO. Also adds IFCW tag for describing initial flow control window in CHLO/SHLO. Not used yet. Merge internal change: 62403534 https://codereview.chromium.org/188183002/ Sync'ing changes with internal tree. https://codereview.chromium.org/184853014/ Merge internal change: 62295877 Make the VER tag required in QUIC CHLO and SHLO messages. Merge internal change: 62286870 https://codereview.chromium.org/186313002/ R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255503

Patch Set 1 #

Patch Set 2 : fix compilation error - added NET_EXPORT_PRIVATE to QuicFixedUint32 #

Patch Set 3 : Fix compilation error - added NET_EXPORT_PRIVATE to QuicFixedUint32 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+737 lines, -530 lines) Patch
M net/net.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/congestion_control/cubic_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/fix_rate_sender.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/congestion_control/fix_rate_sender.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/quic/congestion_control/inter_arrival_probe.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/congestion_control/inter_arrival_probe.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/congestion_control/inter_arrival_sender.h View 3 chunks +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/inter_arrival_sender.cc View 8 chunks +15 lines, -38 lines 0 comments Download
M net/quic/congestion_control/inter_arrival_sender_test.cc View 3 chunks +4 lines, -1 line 0 comments Download
M net/quic/congestion_control/loss_detection_interface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/paced_sender.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/congestion_control/paced_sender.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/congestion_control/pacing_sender.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/congestion_control/pacing_sender.cc View 2 chunks +0 lines, -5 lines 0 comments Download
A net/quic/congestion_control/rtt_stats.h View 1 chunk +61 lines, -0 lines 0 comments Download
A net/quic/congestion_control/rtt_stats.cc View 1 chunk +81 lines, -0 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.h View 2 chunks +5 lines, -3 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.h View 5 chunks +4 lines, -14 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 7 chunks +14 lines, -60 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 5 chunks +15 lines, -9 lines 0 comments Download
M net/quic/congestion_control/tcp_loss_algorithm.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_loss_algorithm.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/congestion_control/tcp_loss_algorithm_test.cc View 6 chunks +27 lines, -11 lines 0 comments Download
M net/quic/congestion_control/time_loss_algorithm.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/congestion_control/time_loss_algorithm.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/quic/congestion_control/time_loss_algorithm_test.cc View 11 chunks +17 lines, -14 lines 0 comments Download
M net/quic/crypto/crypto_protocol.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_server_test.cc View 12 chunks +17 lines, -2 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.cc View 1 chunk +15 lines, -14 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 1 chunk +13 lines, -12 lines 0 comments Download
M net/quic/quic_config.h View 1 7 chunks +94 lines, -32 lines 0 comments Download
M net/quic/quic_config.cc View 9 chunks +125 lines, -41 lines 0 comments Download
M net/quic/quic_config_test.cc View 6 chunks +47 lines, -0 lines 0 comments Download
M net/quic/quic_connection.h View 1 chunk +0 lines, -12 lines 0 comments Download
M net/quic/quic_connection_test.cc View 27 chunks +24 lines, -29 lines 0 comments Download
M net/quic/quic_data_stream_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/quic_framer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_headers_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_headers_stream_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 10 chunks +14 lines, -35 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 17 chunks +30 lines, -50 lines 0 comments Download
M net/quic/quic_unacked_packet_map.h View 4 chunks +6 lines, -8 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 5 chunks +15 lines, -4 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 4 chunks +12 lines, -4 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M net/quic/test_tools/simple_quic_framer.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 2 chunks +0 lines, -5 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 2 chunks +2 lines, -35 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream_test.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M net/tools/quic/test_tools/quic_server_peer.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_server_peer.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (0 generated)
ramant (doing other things)
6 years, 9 months ago (2014-03-06 03:55:42 UTC) #1
Ryan Hamilton
lgtm
6 years, 9 months ago (2014-03-06 05:10:29 UTC) #2
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 9 months ago (2014-03-06 05:48:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/188333003/1
6 years, 9 months ago (2014-03-06 05:51:21 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 06:01:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-06 06:01:59 UTC) #6
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 9 months ago (2014-03-06 06:15:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/188333003/1
6 years, 9 months ago (2014-03-06 06:16:10 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 06:37:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-06 06:37:12 UTC) #10
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 9 months ago (2014-03-06 15:52:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/188333003/1
6 years, 9 months ago (2014-03-06 15:52:20 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 16:16:54 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg
6 years, 9 months ago (2014-03-06 16:16:54 UTC) #14
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 9 months ago (2014-03-06 18:03:01 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/188333003/1
6 years, 9 months ago (2014-03-06 18:05:31 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 18:33:55 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg
6 years, 9 months ago (2014-03-06 18:33:56 UTC) #18
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 9 months ago (2014-03-06 21:32:49 UTC) #19
ramant (doing other things)
The CQ bit was unchecked by rtenneti@chromium.org
6 years, 9 months ago (2014-03-06 21:33:19 UTC) #20
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 9 months ago (2014-03-06 21:37:44 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/188333003/40001
6 years, 9 months ago (2014-03-06 21:49:19 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 23:11:59 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-06 23:12:00 UTC) #24
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 9 months ago (2014-03-06 23:25:05 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/188333003/40001
6 years, 9 months ago (2014-03-06 23:32:02 UTC) #26
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 02:42:05 UTC) #27
Message was sent while issue was closed. 
Change committed as 255503

Powered by Google App Engine
This is Rietveld 408576698