Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1883313003: [compiler] Hoist bailouts out of OptimizedCompileJob. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_interpreter-compiler-2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Hoist bailouts out of OptimizedCompileJob. This hoists all bailouts out of OptimizedCompileJob::CreateGraph into the compiler pipeline. The reason is that this moves them to a point where we can still influence the decision which compiler to pick and hence gives us more freedom with modeling various pipelines. R=neis@chromium.org Committed: https://crrev.com/1c81ad3f661237d734564c64184141702eff81c4 Cr-Commit-Position: refs/heads/master@{#35532}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M src/compiler.cc View 2 2 chunks +15 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
Hey Georg! This conflicts with your generator CL, depending on which one lands first, one ...
4 years, 8 months ago (2016-04-15 09:42:38 UTC) #1
neis
lgtm
4 years, 8 months ago (2016-04-15 12:10:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883313003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883313003/40001
4 years, 8 months ago (2016-04-15 13:25:01 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-15 13:40:54 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 13:42:17 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1c81ad3f661237d734564c64184141702eff81c4
Cr-Commit-Position: refs/heads/master@{#35532}

Powered by Google App Engine
This is Rietveld 408576698