Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issue 1883293006: Revert of Add the missing text input state tracking code to RenderWidgetHostViewMac. (Closed)

Created:
4 years, 8 months ago by EhsanK
Modified:
4 years, 8 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add the missing text input state tracking code to RenderWidgetHostViewMac. (patchset #2 id:20001 of https://codereview.chromium.org/1878523002/ ) Reason for revert: This is needed to revert https://codereview.chromium.org/1652483002/. The original CL caused many regressions. Original issue's description: > Add the missing text input state tracking code to RenderWidgetHostViewMac. > > Following the fix for crbug.com/578167 (CL 1652483002), a small part of > the Mac related code was removed due to bad merging (after Patch 7). > This CL fixes the issue by storing the new values of text input state in > RenderWidgetHostViewMac as reported by the WebContentsImpl. > > BUG=601738 > > Committed: https://crrev.com/46248c7ed4872cffc4ebb0b9da458678f7d7e7a3 > Cr-Commit-Position: refs/heads/master@{#386504} TBR=creis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=601738

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
EhsanK
Created Revert of Add the missing text input state tracking code to RenderWidgetHostViewMac.
4 years, 8 months ago (2016-04-15 19:21:16 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883293006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883293006/1
4 years, 8 months ago (2016-04-15 19:21:41 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 20:11:24 UTC) #5
Charlie Reis
4 years, 8 months ago (2016-04-15 20:46:34 UTC) #6
Message was sent while issue was closed.
This is closed in favor of https://codereview.chromium.org/1889313002/, right?

Powered by Google App Engine
This is Rietveld 408576698