Start disabling GYP by default in runhooks in some configurations.

Start disabling GYP by default in runhooks in some configurations.

The grand GYP disabling is beginning ...

We want to turn of GYP by default in runhooks for configurations that
should only be using GN now.

For now we will only turnxs it off when gyp_chromium is passed the
--running-as-hook flag (which runhooks will now pass), so invoking
build/gyp_chromium will explicitly run. Also, you can set the env var
GYP_CHROMIUM_NO_ACTION=0 and it will explicitly run (setting that var
to =1 will explicitly *not* run and exit early).

This CL takes a conservative first step and turns it off for Linux
hosts that have no GYP_DEFINES set (including command line -D flags
and values pulled in from any supplemental files, chromium.gyp_env,
or ~/.gyp/include.gypi). Subsequent CLs will start broadening this.

R=thakis@chromium.org, brettw@chromium.org, scottmg@chromium.org
BUG=432967
Committed: https://crrev.com/4d1f42d07135d10b5e5dc156c64cd76fde6aec79
Cr-Commit-Position: refs/heads/master@{#387481}

[brettw, 2016-04-14 21:35:15]

lgtm

https://codereview.chromium.org/1883283002/diff/20001/build/gyp_chromium.py
File build/gyp_chromium.py (right):

https://codereview.chromium.org/1883283002/diff/20001/build/gyp_chromium.py#n...
build/gyp_chromium.py:334: print 'If you really want to run this, either run it
explicitly by hand\n'
"run it" -> "run build/gyp_chromium.py"
Most people don't know how to run GYP manually and this is much more convenient
for one-off testing than modifying your eng and re-running hooks.

[Dirk Pranke, 2016-04-14 21:37:18]

On 2016/04/14 21:35:15, brettw wrote:
> "run it" -> "run build/gyp_chromium.py"
> Most people don't know how to run GYP manually and this is much more
convenient
> for one-off testing than modifying your eng and re-running hooks.

Ack.

[Dirk Pranke, 2016-04-14 21:39:54]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[Dirk Pranke, 2016-04-14 21:40:22]

Description was changed from

==========
Start disabling GYP by default in runhooks in some configurations.

The grand GYP disabling is beginning ...

We want to turn of GYP by default in runhooks for configurations that
should only be using GN now.

For now we will only turnxs it off when gyp_chromium is passed the
--running-as-hook flag (which runhooks will now pass), so invoking
build/gyp_chromium will explicitly run. Also, you can set the env var
GYP_CHROMIUM_NO_ACTION=0 and it will explicitly run (setting that var
to =1 will explicitly *not* run and exit early).

This CL takes a conservative first step and turns it off for Linux
hosts that have no GYP_DEFINES set (including command line -D flags
and values pulled in from any supplemental files, chromium.gyp_env,
or ~/.gyp/include.gypi). Subsequent CLs will start broadening this.

R=thakis@chromium.org, brettw@chromium.org
BUG=432967
==========

to

==========
Start disabling GYP by default in runhooks in some configurations.

The grand GYP disabling is beginning ...

We want to turn of GYP by default in runhooks for configurations that
should only be using GN now.

For now we will only turnxs it off when gyp_chromium is passed the
--running-as-hook flag (which runhooks will now pass), so invoking
build/gyp_chromium will explicitly run. Also, you can set the env var
GYP_CHROMIUM_NO_ACTION=0 and it will explicitly run (setting that var
to =1 will explicitly *not* run and exit early).

This CL takes a conservative first step and turns it off for Linux
hosts that have no GYP_DEFINES set (including command line -D flags
and values pulled in from any supplemental files, chromium.gyp_env,
or ~/.gyp/include.gypi). Subsequent CLs will start broadening this.

R=thakis@chromium.org, brettw@chromium.org, scottmg@chromium.org
BUG=432967
==========

[Dirk Pranke, 2016-04-14 21:40:22]

dpranke@chromium.org changed reviewers:
+ scottmg@chromium.org

[commit-bot: I haz the power, 2016-04-14 21:40:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1883283002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1883283002/60001

[commit-bot: I haz the power, 2016-04-14 22:22:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 22:23:00]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[scottmg, 2016-04-14 22:29:57]

lgtm

https://codereview.chromium.org/1883283002/diff/60001/build/gyp_chromium.py
File build/gyp_chromium.py (right):

https://codereview.chromium.org/1883283002/diff/60001/build/gyp_chromium.py#n...
build/gyp_chromium.py:326: if ('--running-as-hook' in args and
Maybe running_as_hook = '--running-as-hook' and use that in the 3 places.

(Does --running-from-deps or --running-via-runhooks sound better to you? Doesn't
matter much.)

[Dirk Pranke, 2016-04-14 22:30:01]

The CQ bit was checked by dpranke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-14 22:30:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1883283002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1883283002/60001

[Dirk Pranke, 2016-04-14 22:36:03]

On 2016/04/14 22:29:57, scottmg wrote:
> lgtm
> 
> https://codereview.chromium.org/1883283002/diff/60001/build/gyp_chromium.py
> File build/gyp_chromium.py (right):
> 
>
https://codereview.chromium.org/1883283002/diff/60001/build/gyp_chromium.py#n...
> build/gyp_chromium.py:326: if ('--running-as-hook' in args and
> Maybe running_as_hook = '--running-as-hook' and use that in the 3 places.

Good idea.

> (Does --running-from-deps or --running-via-runhooks sound better to you?
Doesn't
> matter much.)

We use --running-as-hook in the sysroot hooks, so I thought I'd stick w/ that
for consistency.

[Dirk Pranke, 2016-04-14 22:41:06]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2016-04-14 22:41:06]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org,
scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1883283002/#ps80001
(title: "use variable rather than string")

[commit-bot: I haz the power, 2016-04-14 22:41:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1883283002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1883283002/80001

[commit-bot: I haz the power, 2016-04-15 00:03:06]

Description was changed from

==========
Start disabling GYP by default in runhooks in some configurations.

The grand GYP disabling is beginning ...

We want to turn of GYP by default in runhooks for configurations that
should only be using GN now.

For now we will only turnxs it off when gyp_chromium is passed the
--running-as-hook flag (which runhooks will now pass), so invoking
build/gyp_chromium will explicitly run. Also, you can set the env var
GYP_CHROMIUM_NO_ACTION=0 and it will explicitly run (setting that var
to =1 will explicitly *not* run and exit early).

This CL takes a conservative first step and turns it off for Linux
hosts that have no GYP_DEFINES set (including command line -D flags
and values pulled in from any supplemental files, chromium.gyp_env,
or ~/.gyp/include.gypi). Subsequent CLs will start broadening this.

R=thakis@chromium.org, brettw@chromium.org, scottmg@chromium.org
BUG=432967
==========

to

==========
Start disabling GYP by default in runhooks in some configurations.

The grand GYP disabling is beginning ...

We want to turn of GYP by default in runhooks for configurations that
should only be using GN now.

For now we will only turnxs it off when gyp_chromium is passed the
--running-as-hook flag (which runhooks will now pass), so invoking
build/gyp_chromium will explicitly run. Also, you can set the env var
GYP_CHROMIUM_NO_ACTION=0 and it will explicitly run (setting that var
to =1 will explicitly *not* run and exit early).

This CL takes a conservative first step and turns it off for Linux
hosts that have no GYP_DEFINES set (including command line -D flags
and values pulled in from any supplemental files, chromium.gyp_env,
or ~/.gyp/include.gypi). Subsequent CLs will start broadening this.

R=thakis@chromium.org, brettw@chromium.org, scottmg@chromium.org
BUG=432967
==========

[commit-bot: I haz the power, 2016-04-15 00:03:07]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-15 00:06:23]

Description was changed from

==========
Start disabling GYP by default in runhooks in some configurations.

The grand GYP disabling is beginning ...

We want to turn of GYP by default in runhooks for configurations that
should only be using GN now.

For now we will only turnxs it off when gyp_chromium is passed the
--running-as-hook flag (which runhooks will now pass), so invoking
build/gyp_chromium will explicitly run. Also, you can set the env var
GYP_CHROMIUM_NO_ACTION=0 and it will explicitly run (setting that var
to =1 will explicitly *not* run and exit early).

This CL takes a conservative first step and turns it off for Linux
hosts that have no GYP_DEFINES set (including command line -D flags
and values pulled in from any supplemental files, chromium.gyp_env,
or ~/.gyp/include.gypi). Subsequent CLs will start broadening this.

R=thakis@chromium.org, brettw@chromium.org, scottmg@chromium.org
BUG=432967
==========

to

==========
Start disabling GYP by default in runhooks in some configurations.

The grand GYP disabling is beginning ...

We want to turn of GYP by default in runhooks for configurations that
should only be using GN now.

For now we will only turnxs it off when gyp_chromium is passed the
--running-as-hook flag (which runhooks will now pass), so invoking
build/gyp_chromium will explicitly run. Also, you can set the env var
GYP_CHROMIUM_NO_ACTION=0 and it will explicitly run (setting that var
to =1 will explicitly *not* run and exit early).

This CL takes a conservative first step and turns it off for Linux
hosts that have no GYP_DEFINES set (including command line -D flags
and values pulled in from any supplemental files, chromium.gyp_env,
or ~/.gyp/include.gypi). Subsequent CLs will start broadening this.

R=thakis@chromium.org, brettw@chromium.org, scottmg@chromium.org
BUG=432967

Committed: https://crrev.com/4d1f42d07135d10b5e5dc156c64cd76fde6aec79
Cr-Commit-Position: refs/heads/master@{#387481}
==========

[commit-bot: I haz the power, 2016-04-15 00:06:24]

Patchset 5 (id:??) landed as
https://crrev.com/4d1f42d07135d10b5e5dc156c64cd76fde6aec79
Cr-Commit-Position: refs/heads/master@{#387481}