Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1883273004: Emulate TEXTURE_IMMUTABLE_LEVELS on GL lower than 4.2 (Closed)

Created:
4 years, 8 months ago by Zhenyao Mo
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, bajones
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Emulate TEXTURE_IMMUTABLE_LEVELS on GL lower than 4.2 BUG=603970 TEST=webgl2 conformance, gpu_unittests R=piman@chromium.org,kbr@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/ae9c1908988efd11714c852206d7f0b772888363 Cr-Commit-Position: refs/heads/master@{#387680}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -27 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 chunks +44 lines, -25 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Zhenyao Mo
piman: PTAL kbr: content/test/gpu owner review
4 years, 8 months ago (2016-04-15 18:13:56 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883273004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883273004/1
4 years, 8 months ago (2016-04-15 18:13:59 UTC) #4
piman
lgtm
4 years, 8 months ago (2016-04-15 19:27:35 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 19:47:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883273004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883273004/1
4 years, 8 months ago (2016-04-15 19:52:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 19:56:31 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 19:57:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae9c1908988efd11714c852206d7f0b772888363
Cr-Commit-Position: refs/heads/master@{#387680}

Powered by Google App Engine
This is Rietveld 408576698