Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1883273003: Pass WideStrings without narrowing to c_str in javascript/ (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Pass WideStrings without narrowing to c_str in javascript/ Avoid string duplication when the caller already has one. Committed: https://pdfium.googlesource.com/pdfium/+/018935c9304bebf13fbad20b124d775ccae87fae

Patch Set 1 #

Patch Set 2 : Missed one caller. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -82 lines) Patch
M fpdfsdk/javascript/Document.cpp View 2 chunks +12 lines, -15 lines 0 comments Download
M fpdfsdk/javascript/JS_Value.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/JS_Value.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M fpdfsdk/javascript/PublicMethods.cpp View 3 chunks +6 lines, -9 lines 0 comments Download
M fpdfsdk/javascript/global.cpp View 1 5 chunks +13 lines, -15 lines 0 comments Download
M fpdfsdk/jsapi/fxjs_v8.cpp View 2 chunks +25 lines, -25 lines 0 comments Download
M fpdfsdk/jsapi/include/fxjs_v8.h View 1 chunk +12 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Lei, for review.
4 years, 8 months ago (2016-04-15 17:06:59 UTC) #2
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-15 19:19:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883273003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883273003/20001
4 years, 8 months ago (2016-04-15 20:00:56 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 20:15:17 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/018935c9304bebf13fbad20b124d775ccae8...

Powered by Google App Engine
This is Rietveld 408576698