Bump MinidumpMemoryRegion::max_bytes to 2MB

Bump MinidumpMemoryRegion::max_bytes to 2MB

BUG=https://bugs.chromium.org/p/google-breakpad/issues/detail?id=694
R=mark@chromium.org

Committed: https://chromium.googlesource.com/breakpad/breakpad/+/b39ab626abe81929155570a5324bda7edd736bb8

[Ted Mielczarek, 2016-04-14 19:43:00]

Description was changed from

==========
Bump MinidumpMemoryRegion::max_bytes to 2MB

BUG=694
R=mark@chromium.org
==========

to

==========
Bump MinidumpMemoryRegion::max_bytes to 2MB

BUG=https://bugs.chromium.org/p/google-breakpad/issues/detail?id=694
R=mark@chromium.org
==========

[Ted Mielczarek, 2016-04-14 19:52:06]

I realized I put information in the bug but not here. Firefox uses a 2MB stack
size on Win64, and for stack overflow crashes that means the stackwalker can't
load the stack memory for the crashing thread, so you only get the context
frame. Example:
https://crash-stats.mozilla.com/report/index/5d8f24c1-bb0c-4c88-8011-ad257216...

Bumping this up to 2MB will at least fix these crashes, but it would be nice to
have a better solution here, like getting the memory in chunks.

[Mark Mentovai, 2016-04-14 19:58:13]

LGTM.

Regarding your comments on the code review: please consider migrating to
Crashpad. We have Crashpad clients alive and well on both Windows and Mac. The
roadmap for the existing Breakpad clients only indicates a dead-end, and the
only thing between here and there are potholes and rock slides.

https://codereview.chromium.org/1883253002/diff/1/src/processor/minidump.cc
File src/processor/minidump.cc (right):

https://codereview.chromium.org/1883253002/diff/1/src/processor/minidump.cc#n...
src/processor/minidump.cc:1183: uint32_t MinidumpMemoryRegion::max_bytes_ = 2 *
1024 * 1024;  // 1MB
// 2MB

[Ted Mielczarek, 2016-04-14 20:26:33]

On 2016/04/14 19:58:13, Mark Mentovai wrote:
> LGTM.
> 
> Regarding your comments on the code review: please consider migrating to
> Crashpad. We have Crashpad clients alive and well on both Windows and Mac. The
> roadmap for the existing Breakpad clients only indicates a dead-end, and the
> only thing between here and there are potholes and rock slides.

That's something I've been thinking about recently now that you've got Mac and
Windows support, unfortunately I haven't found the time to tackle it. I'm not
extremely happy about being the sole maintainer of the client bits for those
platforms, but they also haven't needed much work lately so it hasn't been
particularly pressing.

[Ted Mielczarek, 2016-04-14 20:27:28]

Description was changed from

==========
Bump MinidumpMemoryRegion::max_bytes to 2MB

BUG=https://bugs.chromium.org/p/google-breakpad/issues/detail?id=694
R=mark@chromium.org
==========

to

==========
Bump MinidumpMemoryRegion::max_bytes to 2MB

BUG=https://bugs.chromium.org/p/google-breakpad/issues/detail?id=694
R=mark@chromium.org

Committed:
https://chromium.googlesource.com/breakpad/breakpad/+/b39ab626abe81929155570a...
==========

[Ted Mielczarek, 2016-04-14 20:27:29]

Committed patchset #1 (id:1) manually as
b39ab626abe81929155570a5324bda7edd736bb8 (presubmit successful).