OLD | NEW |
1 Multiple repo Chromium trybots | 1 Multiple repo Chromium trybots |
2 ============================== | 2 ============================== |
3 | 3 |
4 When a proposed Skia change will require a change in Chromium or Blink it is | 4 When a proposed Skia change will require a change in Chromium or Blink it is |
5 often helpful to locally create the Chromium and Blink changes and test with the | 5 often helpful to locally create the Chromium and Blink changes and test with the |
6 proposed Skia change. This often happens with Skia API changes and changes | 6 proposed Skia change. This often happens with Skia API changes and changes |
7 which affect Blink layout tests. While simple to do locally, this explains how | 7 which affect Blink layout tests. While simple to do locally, this explains how |
8 to do so on the Chromium trybots. | 8 to do so on the Chromium trybots. |
9 | 9 |
10 The basic idea is to make your Chromium and Blink change in the usual way, but | 10 The basic idea is to make your Chromium and Blink change in the usual way, but |
(...skipping 16 matching lines...) Expand all Loading... |
27 '--server', 'https://codereview.chromium.org', | 27 '--server', 'https://codereview.chromium.org', |
28 '--force', | 28 '--force', |
29 '--ignore_deps', | 29 '--ignore_deps', |
30 '-v', | 30 '-v', |
31 '-v', | 31 '-v', |
32 '--no-auth', | 32 '--no-auth', |
33 '--blacklist', 'DEPS' | 33 '--blacklist', 'DEPS' |
34 ], | 34 ], |
35 }, | 35 }, |
36 | 36 |
| 37 Modify the 'issue' and 'patchset' to the appropriate values. |
| 38 If this is for a project other than Skia, update the 'root_dir' and 'server'. |
| 39 Note that this can be used multiple times to apply multiple issues. |
| 40 |
| 41 To find the patchset number in Rietveld use the URL of the '[raw]' (old UI) or |
| 42 'Raw Patch' (new UI) link on the desired patch. The last segment of this URL |
| 43 has the form 'issue\<issue>_\<patchset>.diff'. |
| 44 |
37 An example of this being used can be seen at | 45 An example of this being used can be seen at |
38 https://crrev.com/1877673002/#ps120001 . | 46 https://crrev.com/1877673002/#ps120001 . |
39 | 47 |
40 | 48 |
41 External changes not in rietveld | 49 External changes not in rietveld |
42 -------------------------------- | 50 -------------------------------- |
43 If the patch is to files where the above is not possible, then it is still | 51 If the patch is to files where the above is not possible, then it is still |
44 possible to patch the files manually by adding the following to | 52 possible to patch the files manually by adding the following to |
45 \<chromium>/src/DEPS in the 'hooks' array just before the 'gyp' hook. | 53 \<chromium>/src/DEPS in the 'hooks' array just before the 'gyp' hook. |
46 | 54 |
(...skipping 13 matching lines...) Expand all Loading... |
60 \<chromium>/src/patch/third_party/skia/include/core/SkPath.h. | 68 \<chromium>/src/patch/third_party/skia/include/core/SkPath.h. |
61 | 69 |
62 An example of this being used can be seen at | 70 An example of this being used can be seen at |
63 https://crrev.com/1866773002/#ps20001 . | 71 https://crrev.com/1866773002/#ps20001 . |
64 | 72 |
65 | 73 |
66 Try the patch | 74 Try the patch |
67 ------------- | 75 ------------- |
68 After committing these \<chromium>/src/DEPS and \<chromium>/src/patch/ changes | 76 After committing these \<chromium>/src/DEPS and \<chromium>/src/patch/ changes |
69 locally, 'git cl upload' can be used in the usual way. Be sure to add | 77 locally, 'git cl upload' can be used in the usual way. Be sure to add |
70 'COMMIT=false' to the issue description to avoid accidentally checking it in. | 78 'COMMIT=false' to the issue description to avoid accidentally checking it in. |
OLD | NEW |