Issue 18832002: Turn the representation changes into a proper HPhase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18832002: Turn the representation changes into a proper HPhase. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer

Modified:
7 years, 5 months ago

Reviewers:
mvstanton, Dmitry Lomov (no reviews)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+226 lines, -142 lines)			Patch
M	src/hydrogen.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	src/hydrogen.cc	View	3 chunks	+2 lines, -136 lines	0 comments	Download
A	src/hydrogen-representation-changes.h	View	1 chunk	+55 lines, -0 lines	0 comments	Download
A	src/hydrogen-representation-changes.cc	View	1 chunk	+167 lines, -0 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

mvstanton

nice to see hydrogen.cc getting less monolithic :). lgtm.

7 years, 5 months ago (2013-07-08 08:59:36 UTC) #2

Benedikt Meurer

7 years, 5 months ago (2013-07-08 09:02:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15541 (presubmit successful).