Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1883193003: Revert of Reupload of "Flock master startup." (Closed)

Created:
4 years, 8 months ago by dsansome
Modified:
4 years, 8 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, hinoka
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Reupload of "Flock master startup." (patchset #2 id:20001 of https://codereview.chromium.org/1892643002/ ) Reason for revert: if [ -n $(ps -p$PID -o pid=) ]; then This doesn't work at all. Check the return code of ps or quote the string. http://o/293111 Original issue's description: > Reupload of "Flock master startup." > > This was reverted because the path manipulation didn't work for internal masters. Original patchset here: https://chromiumcodereview.appspot.com/1883813003/. > > BUG=588118 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299942 TBR=pgervais@chromium.org,dnj@chromium.org,stip@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=588118 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299948

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -46 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M masters/master-common.mk View 2 chunks +4 lines, -4 lines 0 comments Download
M masters/master-common-rules.mk View 2 chunks +9 lines, -14 lines 0 comments Download
D masters/start_master.sh View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
dsansome
Created Revert of Reupload of "Flock master startup."
4 years, 8 months ago (2016-04-15 05:44:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883193003/1
4 years, 8 months ago (2016-04-15 05:44:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=299948
4 years, 8 months ago (2016-04-15 05:44:37 UTC) #4
ghost stip (do not use)
4 years, 8 months ago (2016-04-15 05:48:29 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1885043007/ by stip@chromium.org.

The reason for reverting is: dsansome missed
https://chromiumcodereview.appspot.com/1884873010/ :(.

Powered by Google App Engine
This is Rietveld 408576698