[Password Manager] HTML parsing based client-side form type classifier

components/autofill.gypi

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       # GN version: //components/autofill/core/common
       'target_name': 'autofill_core_common',
       'type': 'static_library',
@@ skipping 472 matching lines @@
             'autofill_core_common',
             'components_strings.gyp:components_strings',
           ],
           'sources': [
             'autofill/content/renderer/autofill_agent.cc',
             'autofill/content/renderer/autofill_agent.h',
             'autofill/content/renderer/form_autofill_util.cc',
             'autofill/content/renderer/form_autofill_util.h',
             'autofill/content/renderer/form_cache.cc',
             'autofill/content/renderer/form_cache.h',
+            'autofill/content/renderer/form_classifier.cc',

[vabr (Chromium), 2016/06/10 13:22:11]

Where do we plan to use form_classifier? If only inside the password_manager
component, then we should place it there. Having password code in the autofill
component is an unfortunate result of some dependencies related to how the
agents in the renderer code work. We should not put more password manager code
to autofill than necessary.

[kolos1, 2016/06/13 14:27:34]

As we discussed in person, the form classifier will be called from
PasswordGenerationAgent. So, I put the classifier in the same location and the
same targets as the agent.

+            'autofill/content/renderer/form_classifier.h',
             'autofill/content/renderer/page_click_listener.h',
             'autofill/content/renderer/page_click_tracker.cc',
             'autofill/content/renderer/page_click_tracker.h',
             'autofill/content/renderer/password_autofill_agent.cc',
             'autofill/content/renderer/password_autofill_agent.h',
             'autofill/content/renderer/password_form_conversion_utils.cc',
             'autofill/content/renderer/password_form_conversion_utils.h',
             'autofill/content/renderer/password_generation_agent.cc',
             'autofill/content/renderer/password_generation_agent.h',
             'autofill/content/renderer/renderer_save_password_progress_logger.cc',
@@ skipping 58 matching lines @@
             ],
           },
           'includes': [
             '../ios/web/js_compile_checked.gypi',
           ],
         },
       ],
     }],
   ],
 }