third_party/WebKit/Source/core/css/ElementRuleCollector.cpp - Issue 1883083002: Introduce Node::containingTreeScope(), which asserts that the node's root is a tree scope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ElementRuleCollector.cpp

Issue 1883083002: Introduce Node::containingTreeScope(), which asserts that the node's root is a tree scope (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: wip Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/ElementRuleCollector.cpp

diff --git a/third_party/WebKit/Source/core/css/ElementRuleCollector.cpp b/third_party/WebKit/Source/core/css/ElementRuleCollector.cpp

index 2f6ed1ab9427b30f27add7f2e922bafa9fcc7066..81c02522e8f530087a44df736069403c94a8d7e6 100644

--- a/third_party/WebKit/Source/core/css/ElementRuleCollector.cpp

+++ b/third_party/WebKit/Source/core/css/ElementRuleCollector.cpp

@@ -117,7 +117,7 @@ void ElementRuleCollector::addElementStyleProperties(const StylePropertySet* pro

static bool rulesApplicableInCurrentTreeScope(const Element* element, const ContainerNode* scopingNode)

{

// Check if the rules come from a shadow style sheet in the same tree scope.

- return !scopingNode || element->treeScope() == scopingNode->treeScope();

+ return !scopingNode || element->rootTreeScope() == scopingNode->rootTreeScope();

}

template<typename RuleDataListType>

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp » ('j') | third_party/WebKit/Source/core/dom/SelectorQuery.cpp » ('J')