Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1883053003: Revert "Use a token to initialise ChannelMojo and MojoApplication everywhere." (Closed)

Created:
4 years, 8 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Use a token to initialise ChannelMojo and MojoApplication everywhere." This reverts commit babb3f34fe20effb72c81104b63b2974271ad88d. BUG=603452 TBR=rockot@chromium.org Committed: https://crrev.com/1c9502415491e04f9199059f59b2e9e278b0e1cf Cr-Commit-Position: refs/heads/master@{#387485}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -68 lines) Patch
M content/browser/gpu/gpu_process_host.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 6 chunks +17 lines, -7 lines 0 comments Download
M content/browser/mojo/mojo_application_host.h View 3 chunks +26 lines, -8 lines 0 comments Download
M content/browser/mojo/mojo_application_host.cc View 2 chunks +56 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 6 chunks +21 lines, -6 lines 0 comments Download
M content/browser/utility_process_host_impl.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M content/child/child_thread_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/child/child_thread_impl.cc View 5 chunks +9 lines, -7 lines 0 comments Download
M content/child/mojo/mojo_application.h View 1 chunk +25 lines, -7 lines 0 comments Download
M content/child/mojo/mojo_application.cc View 2 chunks +44 lines, -3 lines 0 comments Download
M content/common/content_message_generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/in_process_child_thread_params.h View 4 chunks +4 lines, -3 lines 0 comments Download
M content/common/in_process_child_thread_params.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A content/common/mojo/channel_init.h View 1 chunk +41 lines, -0 lines 0 comments Download
A content/common/mojo/channel_init.cc View 1 chunk +32 lines, -0 lines 0 comments Download
A content/common/mojo/mojo_messages.h View 1 chunk +22 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/render_thread_impl_browser_test_ipc_helper.h View 3 chunks +4 lines, -8 lines 0 comments Download
M content/test/render_thread_impl_browser_test_ipc_helper.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M ipc/ipc_message_start.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883053003/1
4 years, 8 months ago (2016-04-14 23:20:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 00:08:33 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 00:16:23 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1c9502415491e04f9199059f59b2e9e278b0e1cf
Cr-Commit-Position: refs/heads/master@{#387485}

Powered by Google App Engine
This is Rietveld 408576698