Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1883053002: Shuffle fields to make simarm and arm agree on the offset of Heap::new_space_.to_. (Closed)

Created:
4 years, 8 months ago by rmacnak
Modified:
4 years, 8 months ago
Reviewers:
jsimmons1, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Shuffle fields to make simarm and arm agree on the offset of Heap::new_space_.top_. Fix non-simulated mips build. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/630458214500a62f785c0fa1fed655a410450f57

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -5 lines) Patch
M runtime/vm/atomic_linux.h View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/dart.cc View 2 chunks +35 lines, -0 lines 0 comments Download
M runtime/vm/heap.h View 1 chunk +4 lines, -3 lines 0 comments Download
M runtime/vm/heap.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
rmacnak
4 years, 8 months ago (2016-04-14 01:19:57 UTC) #2
siva
lgtm
4 years, 8 months ago (2016-04-14 01:41:38 UTC) #3
rmacnak
4 years, 8 months ago (2016-04-14 16:50:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
630458214500a62f785c0fa1fed655a410450f57 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698