Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1883043003: Add RegisterExternallyReferencedObject to PersistenValueMap (Closed)

Created:
4 years, 8 months ago by Marcel Hlopko
Modified:
4 years, 8 months ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add RegisterExternallyReferencedObject to PersistenValueMap PersistentValueMap is used to hold per-world wrappers in the blink. Currently, when we trace wrappers, we visit wrappers in all worlds via this PersistentValueMap. This cl introduces convenient (and faster) way of registering these external references. BUG=468240 LOG=no Committed: https://crrev.com/b60548260055e3b7bda3d7ad77174d002353c162 Cr-Commit-Position: refs/heads/master@{#35523}

Patch Set 1 #

Patch Set 2 : Add DCHECK #

Patch Set 3 : Fix comment #

Total comments: 2

Patch Set 4 : Leave RegisterExternallyReferencedObject private #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M include/v8.h View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M include/v8-util.h View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Marcel Hlopko
ptal
4 years, 8 months ago (2016-04-14 13:27:05 UTC) #3
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1883043003/diff/40001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/1883043003/diff/40001/include/v8.h#newcode6632 include/v8.h:6632: static void RegisterExternallyReferencedObject(internal::Object** object, this should stay private. Can ...
4 years, 8 months ago (2016-04-14 14:28:09 UTC) #4
Marcel Hlopko
https://codereview.chromium.org/1883043003/diff/40001/include/v8.h File include/v8.h (right): https://codereview.chromium.org/1883043003/diff/40001/include/v8.h#newcode6632 include/v8.h:6632: static void RegisterExternallyReferencedObject(internal::Object** object, Done.
4 years, 8 months ago (2016-04-14 14:50:42 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-15 11:56:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1883043003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1883043003/60001
4 years, 8 months ago (2016-04-15 11:56:47 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-15 12:22:24 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 12:23:59 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b60548260055e3b7bda3d7ad77174d002353c162
Cr-Commit-Position: refs/heads/master@{#35523}

Powered by Google App Engine
This is Rietveld 408576698