[Mac] Update tab audio icon to Material Design and tweak close box color.

[Mac] Update tab audio icon to Material Design and tweak close box color.

This change allows Chrome Mac tabs to display the new Material Design vector icon for audio. It also changes the close box color (i.e. the color of the "x") from always being a light color when in an Incognito tab to being based on the theme. With Material Design on the Mac an Incognito tab will use a custom theme (if set), so a light "x" against a light custom theme is invisible.

R=avi@chromium.org, sky@chromium.org
BUG=598777
Committed: https://crrev.com/54de69c06c3b2ff1aed801cf3ed117339fc79ac3
Cr-Commit-Position: refs/heads/master@{#387377}

[shrike, 2016-04-14 00:26:54]

PTAL

sky@
    chrome/browser/ui/tabs/tab_utils.cc

avi@
    everything else

[Avi (use Gerrit), 2016-04-14 02:35:08]

LGTM

Although you are making a minor tweak to the close button (drawing for dark
themes vs drawing for incognito) so you might want to mention that in the
description.

https://codereview.chromium.org/1883033002/diff/1/chrome/browser/ui/cocoa/tab...
File chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa.mm (right):

https://codereview.chromium.org/1883033002/diff/1/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa.mm:82:
affordanceImage_.reset([tabIndicatorImage retain]);
You can do

affordanceImage_.reset(tabIndicatorImage, base::scoped_policy::RETAIN);

although now that I mention it, it's a bit longer.

[sky, 2016-04-14 16:07:30]

LGTM

[shrike, 2016-04-14 18:02:23]

Description was changed from

==========
[Mac] Update tab audio icon to Material Design.

R=avi@chromium.org, sky@chromium.org
BUG=598777
==========

to

==========
[Mac] Update tab audio icon to Material Design and tweak close box color.

This change allows Chrome Mac tabs to display the new Material Design vector
icon for audio. It also changes the close box color (i.e. the color of the "x")
from always being a light color when in an Incognito tab to being based on the
theme. With Material Design on the Mac an Incognito tab will use a custom theme
(if set), so a light "x" against a light custom theme is invisible.

R=avi@chromium.org, sky@chromium.org
BUG=598777
==========

[shrike, 2016-04-14 18:03:14]

On 2016/04/14 02:35:08, Avi wrote:
> LGTM
> 
> Although you are making a minor tweak to the close button (drawing for dark
> themes vs drawing for incognito) so you might want to mention that in the
> description.
> 
>
https://codereview.chromium.org/1883033002/diff/1/chrome/browser/ui/cocoa/tab...
> File chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa.mm (right):
> 
>
https://codereview.chromium.org/1883033002/diff/1/chrome/browser/ui/cocoa/tab...
> chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa.mm:82:
> affordanceImage_.reset([tabIndicatorImage retain]);
> You can do
> 
> affordanceImage_.reset(tabIndicatorImage, base::scoped_policy::RETAIN);
> 
> although now that I mention it, it's a bit longer.

I updated the description. And thanks for the pointer about ...RETAIN - I had no
idea that was an option (but for brevity I will leave it as is).

[shrike, 2016-04-14 18:03:19]

The CQ bit was checked by shrike@chromium.org

[commit-bot: I haz the power, 2016-04-14 18:03:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1883033002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1883033002/1

[commit-bot: I haz the power, 2016-04-14 18:49:43]

Description was changed from

==========
[Mac] Update tab audio icon to Material Design and tweak close box color.

This change allows Chrome Mac tabs to display the new Material Design vector
icon for audio. It also changes the close box color (i.e. the color of the "x")
from always being a light color when in an Incognito tab to being based on the
theme. With Material Design on the Mac an Incognito tab will use a custom theme
(if set), so a light "x" against a light custom theme is invisible.

R=avi@chromium.org, sky@chromium.org
BUG=598777
==========

to

==========
[Mac] Update tab audio icon to Material Design and tweak close box color.

This change allows Chrome Mac tabs to display the new Material Design vector
icon for audio. It also changes the close box color (i.e. the color of the "x")
from always being a light color when in an Incognito tab to being based on the
theme. With Material Design on the Mac an Incognito tab will use a custom theme
(if set), so a light "x" against a light custom theme is invisible.

R=avi@chromium.org, sky@chromium.org
BUG=598777
==========

[commit-bot: I haz the power, 2016-04-14 18:49:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-14 18:51:17]

Description was changed from

==========
[Mac] Update tab audio icon to Material Design and tweak close box color.

This change allows Chrome Mac tabs to display the new Material Design vector
icon for audio. It also changes the close box color (i.e. the color of the "x")
from always being a light color when in an Incognito tab to being based on the
theme. With Material Design on the Mac an Incognito tab will use a custom theme
(if set), so a light "x" against a light custom theme is invisible.

R=avi@chromium.org, sky@chromium.org
BUG=598777
==========

to

==========
[Mac] Update tab audio icon to Material Design and tweak close box color.

This change allows Chrome Mac tabs to display the new Material Design vector
icon for audio. It also changes the close box color (i.e. the color of the "x")
from always being a light color when in an Incognito tab to being based on the
theme. With Material Design on the Mac an Incognito tab will use a custom theme
(if set), so a light "x" against a light custom theme is invisible.

R=avi@chromium.org, sky@chromium.org
BUG=598777

Committed: https://crrev.com/54de69c06c3b2ff1aed801cf3ed117339fc79ac3
Cr-Commit-Position: refs/heads/master@{#387377}
==========

[commit-bot: I haz the power, 2016-04-14 18:51:18]

Patchset 1 (id:??) landed as
https://crrev.com/54de69c06c3b2ff1aed801cf3ed117339fc79ac3
Cr-Commit-Position: refs/heads/master@{#387377}