Switch SkMagnifierImageFilter over to new onFilterImage interface

Switch SkMagnifierImageFilter over to new onFilterImage interface

Additionally, this CL:

adds crop handling to the CPU path (the GPU path handled it but with a bug)

adds a cropRect (to better justify the applyCropRect)

adds a GM to exercise the cropRect

Note: I believe the handling of cropRects and clipping is deeply flawed but, at least, the two paths are consistently flawed now.

TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1882943002

Committed: https://skia.googlesource.com/skia/+/b2a4dc6a350abe3b18ecac719e499600f739a6e2

[robertphillips, 2016-04-13 20:18:32]

Description was changed from

==========
Switch SkMagnifierImageFilter over to new onFilterImage interface
==========

to

==========
Switch SkMagnifierImageFilter over to new onFilterImage interface
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-13 20:29:19]

Description was changed from

==========
Switch SkMagnifierImageFilter over to new onFilterImage interface
==========

to

==========
Switch SkMagnifierImageFilter over to new onFilterImage interface
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-13 21:01:21]

Description was changed from

==========
Switch SkMagnifierImageFilter over to new onFilterImage interface
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Switch SkMagnifierImageFilter over to new onFilterImage interface

Additionally, this CL:

adds crop handling to the CPU path (the GPU path handled it but with a bug)

adds a cropRect (to better justify the applyCropRect)

TBR=reed@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-13 21:01:21]

robertphillips@google.com changed reviewers:
+ reed@google.com, senorblanco@chromium.org, senorblanco@google.com

[robertphillips, 2016-04-13 21:04:06]

Description was changed from

==========
Switch SkMagnifierImageFilter over to new onFilterImage interface

Additionally, this CL:

adds crop handling to the CPU path (the GPU path handled it but with a bug)

adds a cropRect (to better justify the applyCropRect)

TBR=reed@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Switch SkMagnifierImageFilter over to new onFilterImage interface

Additionally, this CL:

adds crop handling to the CPU path (the GPU path handled it but with a bug)

adds a cropRect (to better justify the applyCropRect)

adds a GM to exercise the cropRect

Note: I believe the handling of cropRects and clipping is deeply flawed but, at
least, the two paths are consistently flawed now.

TBR=reed@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-13 21:04:14]

https://codereview.chromium.org/1882943002/diff/40001/src/effects/SkMagnifier...
File src/effects/SkMagnifierImageFilter.cpp (right):

https://codereview.chromium.org/1882943002/diff/40001/src/effects/SkMagnifier...
src/effects/SkMagnifierImageFilter.cpp:329: effectBounds,
these next two "/bounds.width()" used to be "/texture->width()" which caused
some lopsidedness in the result (when have clip/cropRect)

[robertphillips, 2016-04-13 21:17:02]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 21:17:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882943002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882943002/40001

[Stephen White, 2016-04-13 21:23:23]

I'm not sure why we're adding API for crop rect, if we know it's buggy, but I
leave that up to you. I doubt it will ever be used in Chrome, as this filter is
only used for a magnifier effect in ChromeOS, and isn't used in a DAG or web
content.

LGTM

https://codereview.chromium.org/1882943002/diff/40001/include/effects/SkMagni...
File include/effects/SkMagnifierImageFilter.h (right):

https://codereview.chromium.org/1882943002/diff/40001/include/effects/SkMagni...
include/effects/SkMagnifierImageFilter.h:18: sk_sp<SkImageFilter> input,
<soapbox> Not new to this patch, but personally I think it's unfortunate that
we've made the input param non-optional to all the Make() functions. Not so much
for Chrome, where we always pass it, but for Skia as an API, for users who "just
want a blurred circle" for example and are forced to understand the DAG a bit to
do it and pepper their code with nullptr. </soapbox>

https://codereview.chromium.org/1882943002/diff/40001/src/effects/SkMagnifier...
File src/effects/SkMagnifierImageFilter.cpp (right):

https://codereview.chromium.org/1882943002/diff/40001/src/effects/SkMagnifier...
src/effects/SkMagnifierImageFilter.cpp:329: effectBounds,
On 2016/04/13 21:04:14, robertphillips wrote:
> these next two "/bounds.width()" used to be "/texture->width()" which caused
> some lopsidedness in the result (when have clip/cropRect)

You break it, you bought it. :)

[commit-bot: I haz the power, 2016-04-13 21:24:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 21:24:04]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[robertphillips, 2016-04-13 21:33:31]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 21:33:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882943002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882943002/40001

[commit-bot: I haz the power, 2016-04-13 21:38:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 21:38:11]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[robertphillips, 2016-04-14 14:20:16]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-14 14:20:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882943002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882943002/80001

[commit-bot: I haz the power, 2016-04-14 14:40:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 14:40:39]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-04-14 14:53:00]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-04-14 14:53:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
senorblanco@chromium.org
Link to the patchset: https://codereview.chromium.org/1882943002/#ps80001
(title: "update")

[commit-bot: I haz the power, 2016-04-14 14:53:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882943002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882943002/80001

[commit-bot: I haz the power, 2016-04-14 14:54:06]

Description was changed from

==========
Switch SkMagnifierImageFilter over to new onFilterImage interface

Additionally, this CL:

adds crop handling to the CPU path (the GPU path handled it but with a bug)

adds a cropRect (to better justify the applyCropRect)

adds a GM to exercise the cropRect

Note: I believe the handling of cropRects and clipping is deeply flawed but, at
least, the two paths are consistently flawed now.

TBR=reed@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Switch SkMagnifierImageFilter over to new onFilterImage interface

Additionally, this CL:

adds crop handling to the CPU path (the GPU path handled it but with a bug)

adds a cropRect (to better justify the applyCropRect)

adds a GM to exercise the cropRect

Note: I believe the handling of cropRects and clipping is deeply flawed but, at
least, the two paths are consistently flawed now.

TBR=reed@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/b2a4dc6a350abe3b18ecac719e499600f739a6e2
==========

[commit-bot: I haz the power, 2016-04-14 14:54:07]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/b2a4dc6a350abe3b18ecac719e499600f739a6e2