DevTools: minor flame chart speedups.

Source/devtools/front_end/TimelineFlameChart.js

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 180 matching lines @@
         this._totalTime = Math.max(1000, this._endTime - this._startTime);
 
         if (this._mainThread) {
             if (record.type === WebInspector.TimelineModel.RecordType.GPUTask || !!record.thread)
                 return;
         } else {
             if (record.type === WebInspector.TimelineModel.RecordType.Program || !record.thread || record.thread === "gpu")
                 return;
         }
 
-        var recordIndex = this._pushRecord(record, true, level, record.startTime, record.endTime);
-        var currentTime = record.startTime;
-        for (var i = 0; i < record.children.length; ++i) {
-            var childRecord = record.children[i];
-            var childStartTime = childRecord.startTime;
-            var childEndTime = childRecord.endTime;
-            if (childStartTime === childEndTime) {
-                this._appendRecord(childRecord, level + 1);
-                continue;
-            }
-
-            if (currentTime !== childStartTime) {
-                if (recordIndex !== -1) {
-                    this._timelineData.entryTotalTimes[recordIndex] = childStartTime - record.startTime;
-                    recordIndex = -1;
-                } else {
-                    this._pushRecord(record, true, level, currentTime, childStartTime);
-                }
-            }
-            this._pushRecord(record, false, level, childStartTime, childEndTime);
-            this._appendRecord(childRecord, level + 1);
-            currentTime = childEndTime;
+        if (record.children.length) {
+            this._pushRecord(record, true, level, record.startTime, record.startTime +  + record.selfTime);

[alph, 2014/03/06 06:24:46]

Something is wrong here.

[pfeldman, 2014/03/06 11:19:57]

Done.

+            this._pushRecord(record, false, level, record.startTime + record.selfTime, record.endTime);
+        } else {
+            this._pushRecord(record, true, level, record.startTime, record.endTime);
         }
-        if (recordIndex === -1 && recordEndTime !== currentTime || record.children.length === 0)
-            this._pushRecord(record, true, level, currentTime, recordEndTime);
-
+        for (var i = 0; i < record.children.length; ++i)
+            this._appendRecord(record.children[i], level + 1);
         this._maxStackDepth = Math.max(this._maxStackDepth, level + 2);
     },
 
     /**
      * @param {!WebInspector.TimelineModel.Record} record
      * @param {boolean} isSelfSegment
      * @param {number} level
      * @param {number} startTime
      * @param {number} endTime
      * @return {number}
@@ skipping 92 matching lines @@
     requestWindowTimes: function(windowStartTime, windowEndTime)
     {
         this._delegate.requestWindowTimes(windowStartTime, windowEndTime);
     },
 
     /**
      * @param {?RegExp} textFilter
      */
     refreshRecords: function(textFilter)
     {
-        this._dataProvider.reset();
-        this._mainView.reset();
-        this.setSelectedRecord(this._selectedRecord);
     },
 
     reset: function()
     {
         this._automaticallySizeWindow = true;
         this._dataProvider.reset();
         this._mainView.setWindowTimes(0, Infinity);
-        delete this._selectedRecord;
     },
 
     _onRecordingStarted: function()
     {
         this._automaticallySizeWindow = true;
     },
 
     /**
      * @param {!WebInspector.TimelineModel.Record} record
      */
@@ skipping 45 matching lines @@
      */
     highlightSearchResult: function(record, regex, selectRecord)
     {
     },
 
     /**
      * @param {?WebInspector.TimelineModel.Record} record
      */
     setSelectedRecord: function(record)
     {
-        this._selectedRecord = record;
         var entryRecords = this._dataProvider._records;
         for (var entryIndex = 0; entryIndex < entryRecords.length; ++entryIndex) {
             if (entryRecords[entryIndex] === record) {
                 this._mainView.setSelectedEntry(entryIndex);
                 return;
             }
         }
         this._mainView.setSelectedEntry(-1);
-        if (this._selectedElement) {
-            this._selectedElement.remove();
-            delete this._selectedElement;
-        }
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _onEntrySelected: function(event)
     {
         var entryIndex = event.data;
         var record = this._dataProvider._records[entryIndex];
         this._delegate.selectRecord(record);
     },
 
     __proto__: WebInspector.View.prototype
 }