DevTools: minor flame chart speedups.

DevTools: minor flame chart speedups.

R=loislo@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168624

[pfeldman, 2014-03-06 04:49:12]

We definitely need to paint grid on canvas - otherwise paint storms are killing
the performance.

[loislo, 2014-03-06 06:04:51]

lgtm with comments

https://codereview.chromium.org/188293003/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/FlameChart.js (right):

https://codereview.chromium.org/188293003/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/FlameChart.js:829: var dotsWidth =
this._measureWidth(context, "\u2026");
lets also assign it to this._dotWidth

https://codereview.chromium.org/188293003/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/FlameChart.js:923: this._dotsWidth =
this._measureWidth(context, "\u2026");
looks like we don't need this line.

[loislo, 2014-03-06 06:04:52]

lgtm with comments

[alph, 2014-03-06 06:24:46]

https://codereview.chromium.org/188293003/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/FlameChart.js (right):

https://codereview.chromium.org/188293003/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/FlameChart.js:923: this._dotsWidth =
this._measureWidth(context, "\u2026");
Could that be done in the constructor?

https://codereview.chromium.org/188293003/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/FlameChart.js:1042: * @param {Context} context
!Context

https://codereview.chromium.org/188293003/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/FlameChart.js:1048: if (text.length > 20)
I'm wondering does it really help the performance?

https://codereview.chromium.org/188293003/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/TimelineFlameChart.js (right):

https://codereview.chromium.org/188293003/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/TimelineFlameChart.js:202: this._pushRecord(record,
true, level, record.startTime, record.startTime +  + record.selfTime);
Something is wrong here.

[pfeldman, 2014-03-06 11:19:57]

https://codereview.chromium.org/188293003/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/FlameChart.js (right):

https://codereview.chromium.org/188293003/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/FlameChart.js:829: var dotsWidth =
this._measureWidth(context, "\u2026");
On 2014/03/06 06:04:51, loislo wrote:
> lets also assign it to this._dotWidth

I removed this._dotsWidth instead.

https://codereview.chromium.org/188293003/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/FlameChart.js:923: this._dotsWidth =
this._measureWidth(context, "\u2026");
On 2014/03/06 06:04:51, loislo wrote:
> looks like we don't need this line.

Same here, removed

https://codereview.chromium.org/188293003/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/FlameChart.js:923: this._dotsWidth =
this._measureWidth(context, "\u2026");
On 2014/03/06 06:24:46, alph wrote:
> Could that be done in the constructor?

It might depend on the styles, though I am not sure.

https://codereview.chromium.org/188293003/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/FlameChart.js:1042: * @param {Context} context
On 2014/03/06 06:24:46, alph wrote:
> !Context

Done.

https://codereview.chromium.org/188293003/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/FlameChart.js:1048: if (text.length > 20)
On 2014/03/06 06:24:46, alph wrote:
> I'm wondering does it really help the performance?

It prevents from forcing layout.

https://codereview.chromium.org/188293003/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/TimelineFlameChart.js (right):

https://codereview.chromium.org/188293003/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/TimelineFlameChart.js:202: this._pushRecord(record,
true, level, record.startTime, record.startTime +  + record.selfTime);
On 2014/03/06 06:24:46, alph wrote:
> Something is wrong here.

Done.

[pfeldman, 2014-03-06 11:20:48]

Committed patchset #3 manually as r168624 (presubmit successful).

[alph, 2014-03-06 11:23:27]

https://codereview.chromium.org/188293003/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/FlameChart.js (right):

https://codereview.chromium.org/188293003/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/FlameChart.js:1048: if (text.length > 20)
On 2014/03/06 11:19:57, pfeldman wrote:
> On 2014/03/06 06:24:46, alph wrote:
> > I'm wondering does it really help the performance?
> 
> It prevents from forcing layout.

I was asking about that 'if' statement, not about the whole function.

[aandrey, 2014-03-06 12:26:23]

https://codereview.chromium.org/188293003/diff/40001/Source/devtools/front_en...
File Source/devtools/front_end/FlameChart.js (right):

https://codereview.chromium.org/188293003/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/FlameChart.js:1089: this._offsetWidth =
this.element.offsetWidth;
FYI, seems like this also can be delayed until the requestAnuimationFrame
callback