Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1882923005: allow clang toolchains to strip libs as they are built (Closed)

Created:
4 years, 8 months ago by Mostyn Bramley-Moore
Modified:
4 years, 8 months ago
Reviewers:
brettw, agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

allow clang toolchains to strip libs as they are built BUG=509771 Committed: https://crrev.com/7897b6369cea9f28850130385bf85592edc87bb3 Cr-Commit-Position: refs/heads/master@{#388016}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/toolchain/gcc_toolchain.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Mostyn Bramley-Moore
@brettw: please take a look.
4 years, 8 months ago (2016-04-14 21:46:05 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882923005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882923005/1
4 years, 8 months ago (2016-04-15 07:55:19 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 08:35:56 UTC) #7
brettw
lgtm
4 years, 8 months ago (2016-04-18 17:12:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882923005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882923005/1
4 years, 8 months ago (2016-04-18 19:59:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 21:00:28 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 21:02:37 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7897b6369cea9f28850130385bf85592edc87bb3
Cr-Commit-Position: refs/heads/master@{#388016}

Powered by Google App Engine
This is Rietveld 408576698