Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2573)

Unified Diff: chrome/installer/util/move_tree_work_item.cc

Issue 1882923003: Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests
Patch Set: fix build error Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/move_tree_work_item.cc
diff --git a/chrome/installer/util/move_tree_work_item.cc b/chrome/installer/util/move_tree_work_item.cc
index a21db3000589e757adb75a06b5b0415ad7def781..ef682348c636a56dcd19f37c7607bc75f1c19547 100644
--- a/chrome/installer/util/move_tree_work_item.cc
+++ b/chrome/installer/util/move_tree_work_item.cc
@@ -27,7 +27,7 @@ MoveTreeWorkItem::MoveTreeWorkItem(const base::FilePath& source_path,
duplicate_option_(duplicate_option) {
}
-bool MoveTreeWorkItem::Do() {
+bool MoveTreeWorkItem::DoImpl() {
if (!base::PathExists(source_path_)) {
LOG(ERROR) << source_path_.value() << " does not exist";
return false;
@@ -99,7 +99,7 @@ bool MoveTreeWorkItem::Do() {
return true;
}
-void MoveTreeWorkItem::Rollback() {
+void MoveTreeWorkItem::RollbackImpl() {
if (moved_to_dest_path_ && !base::Move(dest_path_, source_path_)) {
PLOG(ERROR) << "Can not move " << dest_path_.value()
<< " to " << source_path_.value();

Powered by Google App Engine
This is Rietveld 408576698