Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10055)

Unified Diff: chrome/installer/util/install_util.cc

Issue 1882923003: Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests
Patch Set: fix build error Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/install_util.cc
diff --git a/chrome/installer/util/install_util.cc b/chrome/installer/util/install_util.cc
index 8b6dfa75deab255b214ff5e749ab7e76949ad6a7..c5568048da4978a6a33234dc036ac5228fa95b7e 100644
--- a/chrome/installer/util/install_util.cc
+++ b/chrome/installer/util/install_util.cc
@@ -285,6 +285,9 @@ void InstallUtil::AddInstallerResultItems(
const base::string16* const launch_cmd,
WorkItemList* install_list) {
DCHECK(install_list);
+ DCHECK(install_list->best_effort());
+ DCHECK(!install_list->rollback_enabled());
+
const HKEY root = system_install ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER;
DWORD installer_result = (GetInstallReturnCode(status) == 0) ? 0 : 1;
install_list->AddCreateRegKeyWorkItem(root, state_key, KEY_WOW64_32KEY);

Powered by Google App Engine
This is Rietveld 408576698