chrome/installer/util/create_dir_work_item.cc - Issue 1882923003: Add best-effort/allow rollback flags on WorkItem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/create_dir_work_item.cc

Issue 1882923003: Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests

Patch Set: fix build error Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/util/create_dir_work_item.cc

diff --git a/chrome/installer/util/create_dir_work_item.cc b/chrome/installer/util/create_dir_work_item.cc

index b2667c12cb16e33bbce92a0ca614cadb96746e85..34215b906d1e94eb038a0d6cf5b4e6949c6c036f 100644

--- a/chrome/installer/util/create_dir_work_item.cc

+++ b/chrome/installer/util/create_dir_work_item.cc

@@ -29,7 +29,7 @@ void CreateDirWorkItem::GetTopDirToCreate() {

return;

}

-bool CreateDirWorkItem::Do() {

+bool CreateDirWorkItem::DoImpl() {

VLOG(1) << "creating directory " << path_.value();

GetTopDirToCreate();

if (top_path_.empty())

@@ -44,7 +44,7 @@ bool CreateDirWorkItem::Do() {

return result;

}

-void CreateDirWorkItem::Rollback() {

+void CreateDirWorkItem::RollbackImpl() {

if (!rollback_needed_)

return;

« no previous file with comments | « chrome/installer/util/create_dir_work_item.h ('k') | chrome/installer/util/create_reg_key_work_item.h » ('j') | chrome/installer/util/work_item.h » ('J')