Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2713)

Unified Diff: chrome/installer/util/copy_tree_work_item.cc

Issue 1882923003: Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests
Patch Set: fix build error Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/copy_tree_work_item.cc
diff --git a/chrome/installer/util/copy_tree_work_item.cc b/chrome/installer/util/copy_tree_work_item.cc
index 57ef3dc7364055ed193e5a1b139e9f9143bf644e..156d7977449af23b14b0de6c166b7a8c635f6133 100644
--- a/chrome/installer/util/copy_tree_work_item.cc
+++ b/chrome/installer/util/copy_tree_work_item.cc
@@ -28,7 +28,7 @@ CopyTreeWorkItem::CopyTreeWorkItem(const base::FilePath& source_path,
copied_to_alternate_path_(false) {
}
-bool CopyTreeWorkItem::Do() {
+bool CopyTreeWorkItem::DoImpl() {
if (!base::PathExists(source_path_)) {
LOG(ERROR) << source_path_.value() << " does not exist";
return false;
@@ -103,7 +103,7 @@ bool CopyTreeWorkItem::Do() {
return true;
}
-void CopyTreeWorkItem::Rollback() {
+void CopyTreeWorkItem::RollbackImpl() {
// Normally the delete operations below should not fail unless some
// programs like anti-virus are inspecting the files we just copied.
// If this does happen sometimes, we may consider using Move instead of

Powered by Google App Engine
This is Rietveld 408576698