Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4768)

Unified Diff: chrome/installer/util/callback_work_item.h

Issue 1882923003: Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests
Patch Set: fix build error Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/callback_work_item.h
diff --git a/chrome/installer/util/callback_work_item.h b/chrome/installer/util/callback_work_item.h
index 3cc22f656ed415a4c1453444d0bffe700ba76b8c..bcfd56c8833caefa4bcc3cde1723693544c19129 100644
--- a/chrome/installer/util/callback_work_item.h
+++ b/chrome/installer/util/callback_work_item.h
@@ -35,9 +35,6 @@ class CallbackWorkItem : public WorkItem {
public:
~CallbackWorkItem() override;
- bool Do() override;
- void Rollback() override;
-
bool IsRollback() const;
private:
@@ -49,7 +46,12 @@ class CallbackWorkItem : public WorkItem {
RS_BACKWARD,
};
- CallbackWorkItem(base::Callback<bool(const CallbackWorkItem&)> callback);
+ explicit CallbackWorkItem(
+ base::Callback<bool(const CallbackWorkItem&)> callback);
+
+ // WorkItem:
+ bool DoImpl() override;
+ void RollbackImpl() override;
base::Callback<bool(const CallbackWorkItem&)> callback_;
RollState roll_state_;

Powered by Google App Engine
This is Rietveld 408576698