Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3243)

Unified Diff: chrome/installer/setup/setup_main.cc

Issue 1882923003: Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests
Patch Set: fix build error Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/setup_main.cc
diff --git a/chrome/installer/setup/setup_main.cc b/chrome/installer/setup/setup_main.cc
index 2e5d289709a69dad8faa7a34a493a3b70a1bcb2a..69efa0fbd4f6208adeec2cf14c633736b08a2c18 100644
--- a/chrome/installer/setup/setup_main.cc
+++ b/chrome/installer/setup/setup_main.cc
@@ -430,10 +430,8 @@ installer::InstallStatus RenameChromeExecutables(
google_update::kRegRenameCmdField);
}
// old_chrome.exe is still in use in most cases, so ignore failures here.
- // Make sure this is the last item in the list because it cannot be rolled
- // back.
- install_list->AddDeleteTreeWorkItem(chrome_old_exe, temp_path.path())->
- set_ignore_failure(true);
+ install_list->AddDeleteTreeWorkItem(chrome_old_exe, temp_path.path())
+ ->set_best_effort(true);
installer::InstallStatus ret = installer::RENAME_SUCCESSFUL;
if (!install_list->Do()) {

Powered by Google App Engine
This is Rietveld 408576698