Issue 1882903002: Code completion refactoring in local contributor, have calls to _addLocalSuggestion() split into th…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1882903002: Code completion refactoring in local contributor, have calls to _addLocalSuggestion() split into th… (Closed)

Created:
4 years, 8 months ago by jwren

Modified:
4 years, 8 months ago

Reviewers:
danrubel

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Code completion refactoring in local contributor, have calls to _addLocalSuggestion() split into the different categories of completions so that fitering, see _addLocalSuggestion_includeTypeNameSuggestions(), can occur before the suggestion gets to _addLocalSuggestion() Take two: can't commit it here: https://codereview.chromium.org/1881153002/ Committed: https://github.com/dart-lang/sdk/commit/6a29eab2c3bb967c21a7da176e55dc48634a25f2

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -20 lines)			Patch
	M	pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart	View		11 chunks	+50 lines, -20 lines	0 comments	Download

Total messages: 4 (2 generated)

jwren

4 years, 8 months ago (2016-04-13 17:15:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6a29eab2c3bb967c21a7da176e55dc48634a25f2 (presubmit successful).