Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1882893003: Add F16 source to the linear pipelin. (Closed)

Created:
4 years, 8 months ago by herb_g
Modified:
4 years, 8 months ago
Reviewers:
reed1
CC:
reviews_skia.org, mtklein, f(malita)
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix think-o for Half name. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -4 lines) Patch
M src/core/SkBitmapProcShader.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M src/core/SkLinearBitmapPipeline.cpp View 1 5 chunks +9 lines, -2 lines 0 comments Download
M src/core/SkLinearBitmapPipeline_sample.h View 1 2 chunks +54 lines, -0 lines 2 comments Download

Messages

Total messages: 21 (9 generated)
herb_g
4 years, 8 months ago (2016-04-14 16:29:09 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882893003/1
4 years, 8 months ago (2016-04-14 16:29:18 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-14 16:41:22 UTC) #8
reed1
https://codereview.chromium.org/1882893003/diff/1/src/core/SkLinearBitmapPipeline.cpp File src/core/SkLinearBitmapPipeline.cpp (right): https://codereview.chromium.org/1882893003/diff/1/src/core/SkLinearBitmapPipeline.cpp#newcode658 src/core/SkLinearBitmapPipeline.cpp:658: sampleStage->initStage<Sampler<PixelHalfSRGB, Blender>>(next, srcPixmap); why is "SRGB" part of this ...
4 years, 8 months ago (2016-04-14 17:25:28 UTC) #9
herb_g
Fix think-o for Half name.
4 years, 8 months ago (2016-04-14 17:44:12 UTC) #10
herb_g
https://codereview.chromium.org/1882893003/diff/1/src/core/SkLinearBitmapPipeline.cpp File src/core/SkLinearBitmapPipeline.cpp (right): https://codereview.chromium.org/1882893003/diff/1/src/core/SkLinearBitmapPipeline.cpp#newcode658 src/core/SkLinearBitmapPipeline.cpp:658: sampleStage->initStage<Sampler<PixelHalfSRGB, Blender>>(next, srcPixmap); On 2016/04/14 17:25:27, reed1 wrote: > ...
4 years, 8 months ago (2016-04-14 17:45:00 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882893003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882893003/20001
4 years, 8 months ago (2016-04-14 17:45:12 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-14 18:03:00 UTC) #15
reed1
lgtm
4 years, 8 months ago (2016-04-14 18:15:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882893003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882893003/20001
4 years, 8 months ago (2016-04-14 18:15:51 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/d5f2e2e7429b643943d2f8a532c65e2498223b5b
4 years, 8 months ago (2016-04-14 18:16:47 UTC) #20
reed1
4 years, 8 months ago (2016-04-14 20:15:44 UTC) #21
Message was sent while issue was closed.
https://codereview.chromium.org/1882893003/diff/20001/src/core/SkLinearBitmap...
File src/core/SkLinearBitmapPipeline_sample.h (right):

https://codereview.chromium.org/1882893003/diff/20001/src/core/SkLinearBitmap...
src/core/SkLinearBitmapPipeline_sample.h:772: const uint32_t* src =
static_cast<const uint32_t*>(vsrc);
Why is src a uint32_t? I'm not very familiar w/ this code, so perhaps this is
correct...

https://codereview.chromium.org/1882893003/diff/20001/src/core/SkLinearBitmap...
src/core/SkLinearBitmapPipeline_sample.h:780: const uint64_t* src =
static_cast<const uint64_t*>(vsrc);
Do we need to add "index" to src ?

Powered by Google App Engine
This is Rietveld 408576698