third_party/WebKit/LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-empty-srcset.html - Issue 1882893002: Remove the line-number flakiness by adding an img element dynamically.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-empty-srcset.html

Issue 1882893002: Remove the line-number flakiness by adding an img element dynamically. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: s/"/'/g per https://www.chromium.org/developers/web-development-style-guide Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/mixedContent/insecure-srcset-in-main-frame-blocked-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-srcset.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-empty-srcset.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-empty-srcset.html b/third_party/WebKit/LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-empty-srcset.html

index 0d705aa6ca5da95ab21199a80b4de370c8fc030b..af1ce4a4cca0f700cb00b9cd46cb813d9bc1ec43 100644

--- a/third_party/WebKit/LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-empty-srcset.html

+++ b/third_party/WebKit/LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-empty-srcset.html

@@ -1,8 +1,12 @@

-<img src="http://127.0.0.1:8080/security/resources/compass.jpg"

- srcset>

window.onload = function() {

- if (window.opener)

- window.opener.postMessage('done', '*');

+ var img = document.createElement('img');

+ img.src = 'http://127.0.0.1:8080/security/resources/compass.jpg';

+ img.srcset = '';

+ img.addEventListener('load', function () {

+ if (window.opener)

+ window.opener.postMessage('done', '*');

+ });

+ document.body.appendChild(img);

};

</script>