Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 1882833006: Revert of Immediately cache compiled scripts. (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Immediately cache compiled scripts. (patchset #2 id:20001 of https://codereview.chromium.org/1890083002/ ) Reason for revert: [Sheriff] Breaks: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/builds/8769 Auto-bisect points to this CL. Original issue's description: > Immediately cache compiled scripts. > > Usually, script compilation is expensive enough to warrant the extra > overhead of caching scripts immediatly. > > BUG=chromium:588900 > R=yangguo@chromium.org > LOG=n > > Committed: https://crrev.com/3533c084d470912384988768c4b3b109304da357 > Cr-Commit-Position: refs/heads/master@{#35527} TBR=yangguo@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:588900 Committed: https://crrev.com/f8a5a4da70d0a8e6dbb1b5c633c2b6b47fe5c3f6 Cr-Commit-Position: refs/heads/master@{#35536}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -11 lines) Patch
M src/objects.cc View 1 chunk +14 lines, -2 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 2 chunks +45 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M test/mjsunit/osr-elements-kind.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
Created Revert of Immediately cache compiled scripts.
4 years, 8 months ago (2016-04-15 14:19:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882833006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882833006/1
4 years, 8 months ago (2016-04-15 14:19:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 14:19:48 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f8a5a4da70d0a8e6dbb1b5c633c2b6b47fe5c3f6 Cr-Commit-Position: refs/heads/master@{#35536}
4 years, 8 months ago (2016-04-15 14:22:00 UTC) #6
jochen (gone - plz use gerrit)
4 years, 8 months ago (2016-04-18 07:00:25 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1901573002/ by jochen@chromium.org.

The reason for reverting is: Fixed webkit_unit_tests.

Powered by Google App Engine
This is Rietveld 408576698